Skip to content

Conversation

@nepyope
Copy link
Collaborator

@nepyope nepyope commented Dec 17, 2025

Add holosoma locomotion from Amazon-FAR

Copilot AI review requested due to automatic review settings December 17, 2025 17:27
@github-actions github-actions bot added documentation Improvements or fixes to the project’s docs examples Issues related to the examples labels Dec 17, 2025
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions github-actions bot added the robots Issues concerning robots HW interfaces label Dec 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the Holosoma whole-body locomotion controller for the Unitree G1 robot and refactors the existing GR00T locomotion example for better consistency. The Holosoma implementation comes from Amazon FAR's open-source project and provides an alternative locomotion policy that supports both FastSAC and PPO variants. The refactoring work aligns naming conventions and code structure between the two locomotion examples.

Key changes:

  • Added new holosoma_locomotion.py example with support for FastSAC (default) and PPO policies
  • Refactored gr00t_locomotion.py variable names and comments for consistency (e.g., locomotion_cmdcmd, groot_locomotion_runrun_step)
  • Updated documentation to include holosoma locomotion instructions

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
examples/unitree_g1/holosoma_locomotion.py New whole-body locomotion controller implementing Holosoma policies from Amazon FAR, with ONNX-based policy loading and KP/KD extraction from model metadata
examples/unitree_g1/gr00t_locomotion.py Refactored for consistency with holosoma implementation - renamed variables, standardized method names, and updated comments/docstrings
docs/source/unitree_g1.mdx Added holosoma locomotion example to documentation and updated section headers for clarity
Comments suppressed due to low confidence (1)

examples/unitree_g1/gr00t_locomotion.py:50

  • Inconsistent type annotations for module-level constants. Either all constants should have type annotations or none should. ACTION_SCALE and CONTROL_DT don't have type annotations while ANG_VEL_SCALE, DOF_POS_SCALE, DOF_VEL_SCALE, and CMD_SCALE do. For consistency, consider either adding type annotations to all constants or removing them from all.
ACTION_SCALE = 0.25
CONTROL_DT = 0.02  # 50Hz
ANG_VEL_SCALE: float = 0.25
DOF_POS_SCALE: float = 1.0
DOF_VEL_SCALE: float = 0.05
CMD_SCALE: list = [2.0, 2.0, 0.25]

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or fixes to the project’s docs examples Issues related to the examples robots Issues concerning robots HW interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants