fix a bug for kwargs in wallx #2714
Open
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pepijn <[email protected]>
github-actions
bot
added
documentation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request aims to improve the WallXPolicy class extensibility and enhance the WALL-OSS documentation with additional resources. However, the main code change has a bug that prevents the intended functionality from working correctly.
Key changes:
- Added
**kwargsparameter toWallXPolicy.__init__method (though not properly forwarded to parent) - Enhanced documentation with direct links to paper, repository, and Hugging Face resources
- Fixed markdown table formatting issues in the README
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/lerobot/policies/wall_x/modeling_wall_x.py |
Added **kwargs parameter to constructor signature, but missing proper forwarding to parent class |
docs/source/policy_walloss_README.md |
Added "Additional Resources" section with links, fixed table formatting, and clarified license information |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the documentation for the WALL-OSS model and makes a minor improvement to the
WallXPolicyclass constructor. The most important changes are grouped below:Documentation improvements:
docs/source/policy_walloss_README.mdto enhance discoverability and resource access.Codebase improvement:
WallXPolicyclass constructor insrc/lerobot/policies/wall_x/modeling_wall_x.pyto accept additional keyword arguments (**kwargs), improving extensibility for future enhancements.