Skip to content

Conversation

@YushunXiang
Copy link
Contributor

@YushunXiang YushunXiang commented Dec 24, 2025

Title

Updated WallXPolicy.__init__ to accept **kwargs and pass them to the superclass initializer, enabling future extensibility.

Type / Scope

  • Type: Bug

Summary / Motivation

This pull request introduces a small update to the initialization method of the WallXPolicy class to allow passing additional keyword arguments. This change improves flexibility for subclassing and integration.

How was this tested

  • Manual checks / dataset runs performed.

How to run locally (reviewer)

  • Run the relevant tests:

    pytest -vs tests/policies/wall_x/test_wallx.py 
  • Run a quick example or CLI (if applicable):

    python src/lerobot/scripts/lerobot_train.py \
        --dataset.repo_id=your_dataset \
        --policy.type=wall_x \
        --output_dir=./outputs/wallx_training \
        --job_name=wallx_training \
        --policy.repo_id=your_repo_id \
        --policy.pretrained_name_or_path=x-square-robot/wall-oss-flow \
        --policy.prediction_mode=diffusion \
        --policy.attn_implementation=eager \
        --steps=3000 \
        --policy.device=cuda \
        --batch_size=32

Checklist (required before merge)

  • Linting/formatting run (pre-commit run -a)
  • All tests pass locally (pytest)
  • Documentation updated
  • CI is green

Reviewer notes

  • Anything the reviewer should focus on (performance, edge-cases, specific files) or general notes.
  • Anyone in the community is free to review the PR.

@wut19 @pkooij

Copilot AI review requested due to automatic review settings December 24, 2025 18:03
@github-actions github-actions bot added the policies Items related to robot policies label Dec 24, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds **kwargs parameter to the WallXPolicy.__init__ method to enable passing additional keyword arguments through the initialization chain. While this aims to improve flexibility for future extensibility, the implementation is inconsistent with existing patterns in the codebase.

Key Changes

  • Modified WallXPolicy.__init__ signature to accept **kwargs
  • Updated the superclass __init__ call to forward **kwargs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

policies Items related to robot policies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant