Update lint script to not tolerate warnings during linter runs #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalrus
approved these changes
Jun 21, 2024
gytis-ivaskevicius
approved these changes
Jun 21, 2024
ce0la
force-pushed
the
fail-linter-on-warning
branch
from
772dafe to
06542f5
Compare
|
@ce0la you can check where eslint is used in other places: |
ce0la
force-pushed
the
fail-linter-on-warning
branch
from
06542f5 to
daaa5d5
Compare
ce0la
force-pushed
the
fail-linter-on-warning
branch
from
daaa5d5 to
f761e8d
Compare
pczeglik-iohk
requested changes
Jun 25, 2024
There was a problem hiding this comment.
Hi @ce0la,
If you like to proceed with this PR, you need to fix estlint warnings in apps/browser-extension-wallet.
Smoke Tests job fails on linting it. Check this output: https://github.com/input-output-hk/lace/actions/runs/9654217184/job/26628262898
|
Allure Report
smokeTests: ✅ test report for e67a19a5
|
pczeglik-iohk
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
This PR configures the CI to fail if one or more warnings are thrown in the linting job.
Testing
Run workflowbutton and selectfail-linter-on-warningfrom the branch selector dropdownRun workflowand wait for a few seconds while the workflow gets scheduled