-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1274 - various nginx batch improvements #1286
Conversation
@bwbroersma I'm having some trouble getting batch auth apply to /, conditional on the batch setting. I bet I'll figure it out eventually, but you might be a bit more familiar with it? The templating is also really limited. The changes in the last commit definitely do not work right. |
@mxsasha sorry for the late reply:
I think BATCH and BASIC_AUTH should work similar, so I would go for option 3, but it's also an option to rewrite the BASIC_AUTH logic. It would be nice to add a hint about htpasswd and the link to authentication.sh, since it took me a few seconds the first time. |
5686208
to
8e137e2
Compare
@bwbroersma any clue what I am missing in 0c6e797 ? |
This is bad practice, and we should not be enabling it.
This reverts commit 38daa5f.
e218824
to
6b1e70b
Compare
* The content-type for openapi.yaml must be application/yaml * Security.txt and openapi.yaml are always accessible. * We will have a single list of users and passwords in a htpasswd file, editable through the commands we recently added. * There are three modes: * single test open (enable_batch=False, so no batch URLs available) has no auth at all * batch mode (enable_batch=True) has auth on all URLs except result reports * single test closed (auth_all_urls=True, enable_batch=False) has auth on all URLs. * The settings BASIC_AUTH and BASIC_AUTH_RAW are removed. (cherry picked from commit e761d30)
* The content-type for openapi.yaml must be application/yaml * Security.txt and openapi.yaml are always accessible. * We will have a single list of users and passwords in a htpasswd file, editable through the commands we recently added. * There are three modes: * single test open (enable_batch=False, so no batch URLs available) has no auth at all * batch mode (enable_batch=True) has auth on all URLs except result reports * single test closed (auth_all_urls=True, enable_batch=False) has auth on all URLs. * The settings BASIC_AUTH and BASIC_AUTH_RAW are removed. (cherry picked from commit e761d30)
* The content-type for openapi.yaml must be application/yaml * Security.txt and openapi.yaml are always accessible. * We will have a single list of users and passwords in a htpasswd file, editable through the commands we recently added. * There are three modes: * single test open (enable_batch=False, so no batch URLs available) has no auth at all * batch mode (enable_batch=True) has auth on all URLs except result reports * single test closed (auth_all_urls=True, enable_batch=False) has auth on all URLs. * The settings BASIC_AUTH and BASIC_AUTH_RAW are removed. (cherry picked from commit e761d30)
(cherry picked from commit c025ade)
* The content-type for openapi.yaml must be application/yaml * Security.txt and openapi.yaml are always accessible. * We will have a single list of users and passwords in a htpasswd file, editable through the commands we recently added. * There are three modes: * single test open (enable_batch=False, so no batch URLs available) has no auth at all * batch mode (enable_batch=True) has auth on all URLs except result reports * single test closed (auth_all_urls=True, enable_batch=False) has auth on all URLs. * The settings BASIC_AUTH and BASIC_AUTH_RAW are removed. (cherry picked from commit e761d30)
(cherry picked from commit c025ade)
No description provided.