Skip to content

feat: Improve ExpirationTimePicker component #7782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 25, 2024
Merged

feat: Improve ExpirationTimePicker component #7782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cb166e8
refactor: improve expirationTimePicker componente
evavirseda Dec 13, 2023
6f658c5
Merge branch 'develop' into feat/improve-expirationTimePicker-component
evavirseda Dec 14, 2023
bf6f463
fix:revert changes to expiration time picker
brancoder Dec 19, 2023
c3834d8
Merge branch 'develop' into feat/improve-expirationTimePicker-component
brancoder Dec 19, 2023
b5cd270
fix: persist expiration time picker value when toggling gift storage …
brancoder Dec 19, 2023
3bbac08
Merge branch 'develop' into feat/improve-expirationTimePicker-component
evavirseda Jan 9, 2024
d05fcd1
Merge branch 'develop' into feat/improve-expirationTimePicker-component
begonaalvarezd Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/desktop/components/popups/send/SendConfirmationPopup.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
let visibleSurplus: number | undefined = undefined

let isPreparingOutput = false

$: expirationTimePicker?.setNull(giftStorageDeposit)

$: isBaseTokenTransfer =
Expand Down
3 changes: 3 additions & 0 deletions packages/shared/components/ExpirationTimePicker.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,11 @@
if (bool && value) {
storedValue = value
value = null
previouslySelectedPeriod = selectedTimePeriod
selectedTimePeriod = TimePeriod.None
} else {
value = storedValue ?? value
selectedTimePeriod = previouslySelectedPeriod
}
}

Expand Down