feat: Improve ExpirationTimePicker component

[evavirseda]

Summary

Partialy resolves the issue #7710, mainly this part:

There is some "remember previous value" logic in the component that causes bugs. Case found by Branko in the Refactor send flow PR (#7608)

We can open a new issue for expiration timepicker improvement because it would be a big refactor

Close #7710

...

Changelog

- Remove unnecessary prop (initialSelected)
- Cleanup code

Testing

Platforms

Please select any platforms where your changes have been tested.

• Desktop
  • MacOS
  • Linux
  • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

• I have followed the contribution guidelines for this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or modified tests that prove my changes work as intended
• I have verified that new and existing unit tests pass locally with my changes
• I have verified that my latest changes pass CI workflows for testing and linting
• I have made corresponding changes to the documentation

[brancoder]

There are a lot of moving parts in the ExpirationTimePicker:

• Toggling giftStoragDeposit Button
• Setting Date to expiration time picker initially and also when returning from unlock stronghold popup
• be cautious to not rebuildTransactionOutput if not intended by changing expiration date

In regards to this part of the issue:

There is some "remember previous value" logic in the component that causes bugs. Case found by Branko in the Refactor send flow PR (#7608)

In the original code this can be fix with this change to the setNull function:

export function setNull(bool: boolean): void {
        if (bool && value) {
            storedValue = value
            value = null
            previouslySelectedPeriod = selectedTimePeriod
            selectedTimePeriod = TimePeriod.None
        } else {
            value = storedValue ?? value
            selectedTimePeriod = previouslySelectedPeriod
        }
    }

setNull was used when toggling giftStorageDeposit button but it wasn't tracking and resetting all the variables correctly.

[brancoder]

Reverted changes and added a fix for "remember previous value" from this issue #7710

[evavirseda]

Reverted changes and added a fix for "remember previous value" from this issue #7710

LGTM!

[cpl121]

LGTM