refactor(starfish): replace string-based source tracking with TransactionSource enum #8964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Refactored transaction source tracking in the Starfish consensus implementation to use a type-safe enum instead of string literals for better maintainability and type safety.
Changes:
TransactionSourceenum indag_state.rswith variants:TransactionSynchronizer,BlockStreaming,ShardReconstructor, andTestDagState::add_transactions()to acceptTransactionSourceinstead of&strBenefits:
DagStatewhere it's primarily usedLinks to any relevant issues
Fixes #8774
How the change has been tested