Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Actions default durability QoS to VOLATILE #31

Conversation

mauropasse
Copy link

@mauropasse mauropasse commented May 2, 2024

The default policy DURABILITY_TRANSIENT_LOCAL set for action goal's "status" doesn't seem to make sense because:

  • A late joiner subscription would receive messages published in the past by some publisher.

For Actions this means:

  • A newly created ActionClient would receive old goal statuses sent in the past by some ActionServer .
  • This can't happen as the ActionClient was not yet created, so ActionServer couldn't have had sent messages.
  • Bug: It actually can happen - multiple clients with same name - They all receive statuses from server, but they silently discard it (only the client making the request processes that status message).

ros2#1155

@alsora alsora merged commit 115f926 into irobot-ros:irobot-humble May 8, 2024
@mauropasse mauropasse deleted the mauro/irobot-humble-change-default-action-qos branch May 8, 2024 16:03
apojomovsky pushed a commit to apojomovsky/rcl that referenced this pull request Jun 26, 2024
…change-default-action-qos

Change Actions default durability QoS to VOLATILE
apojomovsky pushed a commit that referenced this pull request Aug 12, 2024
…ault-action-qos

Change Actions default durability QoS to VOLATILE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants