Skip to content

Commit 7103e84

Browse files
authored
Fixes offset from object obs for Franka stacking env when using parallel envs (#1839)
# Description <!-- Thank you for your interest in sending a pull request. Please make sure to check the contribution guidelines. Link: https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html --> The "object" obs group in the Franka stacking environment contains the absolute position of each of the cubes. At the moment they are being returned as world positions which include the env offset if running multiple envs in parallel, causing inconsistent position values. Fixes: Eliminates the environment offset from the cube positions in the "object" obs group of the Franka stacking environment by subtracting out the environment origin. <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Screenshots Please attach before and after screenshots of the change if applicable. <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
1 parent 7ebcd46 commit 7103e84

File tree

3 files changed

+17
-7
lines changed

3 files changed

+17
-7
lines changed

source/isaaclab_tasks/config/extension.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[package]
22

33
# Note: Semantic Versioning is used: https://semver.org/
4-
version = "0.10.22"
4+
version = "0.10.23"
55

66
# Description
77
title = "Isaac Lab Environments"

source/isaaclab_tasks/docs/CHANGELOG.rst

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,16 @@
11
Changelog
22
---------
33

4+
0.10.23 (2025-02-11)
5+
~~~~~~~~~~~~~~~~~~~~
6+
7+
Fixed
8+
^^^^^
9+
10+
* Fixed the inconsistent object pos observations in the ``Isaac-Stack-Cube-Franka`` environment when using parallel envs by
11+
subtracting out the env origin from each object pos observation.
12+
13+
414
0.10.22 (2025-01-14)
515
~~~~~~~~~~~~~~~~~~~~
616

source/isaaclab_tasks/isaaclab_tasks/manager_based/manipulation/stack/mdp/observations.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -147,11 +147,11 @@ def object_obs(
147147

148148
return torch.cat(
149149
(
150-
cube_1_pos_w,
150+
cube_1_pos_w - env.scene.env_origins,
151151
cube_1_quat_w,
152-
cube_2_pos_w,
152+
cube_2_pos_w - env.scene.env_origins,
153153
cube_2_quat_w,
154-
cube_3_pos_w,
154+
cube_3_pos_w - env.scene.env_origins,
155155
cube_3_quat_w,
156156
gripper_to_cube_1,
157157
gripper_to_cube_2,
@@ -225,11 +225,11 @@ def instance_randomize_object_obs(
225225

226226
return torch.cat(
227227
(
228-
cube_1_pos_w,
228+
cube_1_pos_w - env.scene.env_origins,
229229
cube_1_quat_w,
230-
cube_2_pos_w,
230+
cube_2_pos_w - env.scene.env_origins,
231231
cube_2_quat_w,
232-
cube_3_pos_w,
232+
cube_3_pos_w - env.scene.env_origins,
233233
cube_3_quat_w,
234234
gripper_to_cube_1,
235235
gripper_to_cube_2,

0 commit comments

Comments
 (0)