Skip to content

Commit 93fd212

Browse files
Adds collision approximation choices convert_mesh.py (#1716)
Add missing collision approximation choices # Description Add some missing collision approximation options in convert_mesh.py file. Some collision approximation options were missing in the code, but the MeshConverterCfg class has them as possible options https://github.com/isaac-sim/IsaacLab/blob/21173c3e933a9236d6eb5eb2adb903494ba9a418/source/standalone/tools/convert_mesh.py#L60 https://github.com/isaac-sim/IsaacLab/blob/21173c3e933a9236d6eb5eb2adb903494ba9a418/source/extensions/omni.isaac.lab/omni/isaac/lab/sim/converters/mesh_converter_cfg.py#L39-L41 Fixes #1713 (comment) ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: Virgilio Gomez Lambo <[email protected]>
1 parent 0f58b3e commit 93fd212

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CONTRIBUTORS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ Guidelines for modifications:
103103
* Stephan Pleines
104104
* Tyler Lum
105105
* Victor Khaustov
106+
* Virgilio Gómez Lambo
106107
* Vladimir Fokow
107108
* Wei Yang
108109
* Xavier Nal

scripts/tools/convert_mesh.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
"--collision-approximation",
5858
type=str,
5959
default="convexDecomposition",
60-
choices=["convexDecomposition", "convexHull", "none"],
60+
choices=["convexDecomposition", "convexHull", "boundingCube", "boundingSphere", "meshSimplification", "none"],
6161
help=(
6262
'The method used for approximating collision mesh. Set to "none" '
6363
"to not add a collision mesh to the converted mesh."

0 commit comments

Comments
 (0)