Skip to content

Commit b08422e

Browse files
committed
update velocity_limit docstring and clean up test_articulation
1 parent a0e0a29 commit b08422e

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

source/isaaclab/isaaclab/actuators/actuator_cfg.py

+6
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,11 @@ class ActuatorBaseCfg:
4141
"""Velocity limit of the joints in the group. Defaults to None.
4242
4343
This limit is used by the actuator model. If None, the limit is set to the value specified in the USD joint prim.
44+
45+
.. note::
46+
47+
velocity_limit is not used in ActuatorBaseCfg but is provided for inherited version like
48+
:class:`omni.isaac.lab.actuators.DCMotor`.
4449
"""
4550

4651
effort_limit_sim: dict[str, float] | float | None = None
@@ -55,6 +60,7 @@ class ActuatorBaseCfg:
5560
5661
If None, the limit is set to the value specified in the USD joint prim. Resulting solver solutions will constrain
5762
velocities by these limits. If velocity limits are too tight issues with solver convergence may occur.
63+
5864
"""
5965

6066
stiffness: dict[str, float] | float | None = MISSING

source/isaaclab/test/assets/test_articulation.py

-4
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ def generate_articulation_cfg(
4343
articulation_type: Literal["humanoid", "panda", "anymal", "shadow_hand", "single_joint"],
4444
stiffness: float | None = 10.0,
4545
damping: float | None = 2.0,
46-
vel_limit: float | None = 100.0,
47-
effort_limit: float | None = 400.0,
4846
vel_limit_sim: float | None = None,
4947
effort_limit_sim: float | None = None,
5048
) -> ArticulationCfg:
@@ -77,8 +75,6 @@ def generate_articulation_cfg(
7775
actuators={
7876
"joint": ImplicitActuatorCfg(
7977
joint_names_expr=[".*"],
80-
effort_limit=effort_limit,
81-
velocity_limit=vel_limit,
8278
effort_limit_sim=effort_limit_sim,
8379
velocity_limit_sim=vel_limit_sim,
8480
stiffness=0.0,

0 commit comments

Comments
 (0)