Skip to content

Commit d18f0c2

Browse files
authored
Fixes Isaac Sim executable on pip installation (#1172)
# Description This PR fix #831 by taking into account the Isaac Sim installation using PIP - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
1 parent c81550a commit d18f0c2

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

isaaclab.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ if errorlevel 1 (
8181
set isaacsim_exe=!isaac_path!\isaac-sim.bat
8282
) else (
8383
rem if isaac sim installed from pip
84-
set isaacsim_exe=isaacsim
84+
set isaacsim_exe=isaacsim omni.isaac.sim
8585
)
8686
rem check if there is a python path available
8787
if not exist "%isaacsim_exe%" (

isaaclab.sh

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,14 @@ extract_isaacsim_exe() {
9090
local isaacsim_exe=${isaac_path}/isaac-sim.sh
9191
# check if there is a python path available
9292
if [ ! -f "${isaacsim_exe}" ]; then
93-
echo "[ERROR] No Isaac Sim executable found at path: ${isaacsim_exe}" >&2
94-
exit 1
93+
# check for installation using Isaac Sim pip
94+
if [ $(python -m pip list | grep -c 'isaacsim-rl') -gt 0 ]; then
95+
# Isaac Sim - Python packages entry point
96+
local isaacsim_exe="isaacsim omni.isaac.sim"
97+
else
98+
echo "[ERROR] No Isaac Sim executable found at path: ${isaac_path}" >&2
99+
exit 1
100+
fi
95101
fi
96102
# return the result
97103
echo ${isaacsim_exe}

0 commit comments

Comments
 (0)