Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] Add missing collision approximation choices #1713

Open
1 of 2 tasks
virgilio96upm opened this issue Jan 23, 2025 · 1 comment · May be fixed by #1716
Open
1 of 2 tasks

[Proposal] Add missing collision approximation choices #1713

virgilio96upm opened this issue Jan 23, 2025 · 1 comment · May be fixed by #1716
Assignees
@kellyguo11
Labels
enhancement New feature or request

Comments

@virgilio96upm
Copy link

virgilio96upm commented Jan 23, 2025 •
edited
Loading

Proposal

Add the missing collision approximation choices in the convert_mesh.py file.

Motivation

I was using the convert_mesh tool available and checked that some collision approximation choices were missing in the .py code but the MeshConverterCfg Class has them as possible choices.

Alternatives

just replace the following line (https://github.com/isaac-sim/IsaacLab/blob/21173c3e933a9236d6eb5eb2adb903494ba9a418/source/standalone/tools/convert_mesh.py#L60C5-L60C59) with

choices=["convexDecomposition", "convexHull", "boundingCube", "boundingSphere", "meshSimplification", "none"],

Checklist

  • I have checked that there is no similar issue in the repo

Acceptance Criteria

  • Update the choices list to allow for more options to import mesh assets
@RandomOakForest RandomOakForest added the enhancement New feature or request label Jan 23, 2025
@RandomOakForest
Copy link
Collaborator

Thank you for your interest in Isaac Lab and for posting this proposal. Would you be interested in submitting a PR? Thank you!

@virgilio96upm virgilio96upm linked a pull request Jan 23, 2025 that will close this issue
Open
6 tasks
@kellyguo11 kellyguo11 self-assigned this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kellyguo11 kellyguo11

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add collision approximation choices convert_mesh.py MetaToolEU/IsaacLab
3 participants
@kellyguo11 @virgilio96upm @RandomOakForest