Skip to content

[Bug Report] Modifiers and history buffer cannot be used together in observation term #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks done
ZiwenZhuang opened this issue May 10, 2025 · 1 comment · May be fixed by #2461
Open
3 tasks done

[Bug Report] Modifiers and history buffer cannot be used together in observation term #2460

ZiwenZhuang opened this issue May 10, 2025 · 1 comment · May be fixed by #2461
Labels
bug Something isn't working

Comments

@ZiwenZhuang
Copy link

ZiwenZhuang commented May 10, 2025

Describe the bug

Modifiers and history buffer cannot be used together in observation term.

Steps to reproduce

Setting any of the observation term with both history_length and class-based modifiers (e.g. Integrator) will lead to dimension mismatch error.

For example

from isaaclab.utils import IntegratorCfg

actions = ObsTerm(
    func=mdp.last_action,
    history_length=5,
    modifiers=[
        IntegratorCfg(dt=0.02),
    ],
)

Additional context

Running on IsaacLab 2.1.0

Checklist

  • I have checked that there is no similar issue in the repo (required)
  • I have checked that the issue is not in running Isaac Sim itself and is related to the repo

Acceptance Criteria

Add the criteria for which this task is considered done. If not known at issue creation time, you can add this once the issue is assigned.

  • Fixing by moving observation_manager's history buffer initialization after the initialization of modifiers.
@RandomOakForest
Copy link
Collaborator

Thanks for posting this and adding the PR. The team will review.

@RandomOakForest RandomOakForest added the bug Something isn't working label May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants