Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed function prototype (01 08 02) #718

Merged
merged 3 commits into from
Mar 29, 2025
Merged

Fixed function prototype (01 08 02) #718

merged 3 commits into from
Mar 29, 2025

Conversation

Andrii256
Copy link
Contributor

No description provided.

@Andrii256
fixed mistakes and simplified explanation
b05d99e 
**In chapter 01-08-02 prototype-inheritance**

There were many mistakes.
And some of sentences were correct, but they were "unnatural" in Ukrainian and make understanding more difficult.
@Andrii256
fixed translation of tasks
32e58ad 
fixed typos and simplified explanation

For tasks

**In chapter 01-08-02 prototype-inheritance**

There were many mistakes.
And some of sentences were correct, but they were "unnatural" in Ukrainian and make understanding more difficult.
@javascript-translate-bot javascript-translate-bot requested review from a team February 21, 2025 21:12
dolgachio
dolgachio requested changes Mar 8, 2025
View reviewed changes
Copy link
Collaborator

@dolgachio dolgachio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую за виправлення, будь ласка подивіться мої коментарі з пропозиціями змін.
Щодо картинок, на деяких з них текст не влазить після зміни.

Також, хочу звернути вашу увагу, що раніше було вирішено, замість "default" використовувати переклад "типовий" . Ось тут можна подивитись це обговорення #147

@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

3 similar comments
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@Andrii256
Copy link
Contributor Author

Вибачте за затримку, теж трохи не було часу.
Все крім одного зарезолвив. Якщо принципово, то можу й ту зміну зарезолвити.

@dolgachio dolgachio merged commit 426a7d1 into javascript-tutorial:master Mar 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolgachio dolgachio dolgachio approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andrii256 @javascript-translate-bot @dolgachio