CU-86bzn78dn - Build issue in the Main branch #280
Conversation
|
Task linked: CU-86bzn78dn Build issue in the Main branch |
|
Warning Rate limit exceeded@sushantpatil1214 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 24 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe recent updates to the build scripts enhance modularity and flexibility by allowing users to specify build tags through command-line arguments, defaulting to "ci-test-main" when none are provided. Additionally, a new variable Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- JeMPI_Apps/build-all-java.sh (1 hunks)
- JeMPI_Apps/build-all-ui.sh (1 hunks)
Additional comments not posted (4)
JeMPI_Apps/build-all-ui.sh (2)
5-9: LGTM! Conditional mechanism for settingtag_to_useis well-implemented.The code correctly sets a default value for
tag_to_useif no command-line arguments are provided.
12-12: LGTM! Invocation ofbuild-image.shwith theTAGenvironment variable is correct.The
TAGenvironment variable is correctly set and passed tobuild-image.sh, ensuring flexibility in the build process.JeMPI_Apps/build-all-java.sh (2)
9-13: LGTM! Conditional mechanism for settingtag_to_useis well-implemented.The code correctly sets a default value for
tag_to_useif no command-line arguments are provided.
20-41: LGTM! Build commands withCI=false TAG=$tag_to_useprefix are correct.The
CI=false TAG=$tag_to_useprefix is correctly added to the build commands, ensuring that the specified tag is passed to the build process.
There was a problem hiding this comment.
@MatthewErispe On both files I'm just not sure about hardcoding that CI value. If that's not an issue then this is good to go.
There was a problem hiding this comment.
@sushantpatil1214 If we hardcode the CI flag like this, wouldn't that cause issues with other flows, like Platform / CI flows? Thinking it might be better to declare it once at the top of the file and check if it's set? For example:
CI=${CI:-false}
if [ $# -eq 0 ]; then
tag_to_use="ci-test-main"
else
tag_to_use=$1
fi
There was a problem hiding this comment.
@martino-jembi
Already same hard-coded inbuild-all-ci.shfile. I don't think it will impact.
But it sounds good to me.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- JeMPI_Apps/build-all-ci.sh (2 hunks)
- JeMPI_Apps/build-all-java.sh (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- JeMPI_Apps/build-all-java.sh
Additional comments not posted (2)
JeMPI_Apps/build-all-ci.sh (2)
6-6: Good practice: Introduce a default variable.The introduction of the
CIvariable with a default value oftrueenhances maintainability and flexibility.
29-53: Consistent usage of theCIvariable.The usage of the
CIvariable in the build commands ensures consistency and maintainability.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- JeMPI_Apps/build-all-ci.sh (2 hunks)
- JeMPI_Apps/build-all-java.sh (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- JeMPI_Apps/build-all-ci.sh
- JeMPI_Apps/build-all-java.sh
Summary by CodeRabbit
New Features
Bug Fixes
Chores