Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-86bzn78dn - Build issue in the Main branch #280

Merged
merged 4 commits into from
Jul 22, 2024
+32 −18
Merged

CU-86bzn78dn - Build issue in the Main branch #280

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a67f59
CU-86bzn78dn - Build issue in the Main branch
sushantpatil1214 Jul 19, 2024
6e979b9
Added variable for CI
sushantpatil1214 Jul 19, 2024
6f7d7cc
Added variable for CI
sushantpatil1214 Jul 19, 2024
bc5855e
Added variable for CI
sushantpatil1214 Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions JeMPI_Apps/build-all-ci.sh
View file
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@
set -e
set -u

CI=${CI:-true}
if [ $# -eq 0 ]; then
tag_to_use="ci-test-main"
else
@@ -25,29 +26,29 @@ popd
docker buildx create --name container --driver=docker-container

pushd JeMPI_AsyncReceiver
CI=true TAG=$tag_to_use ./build.sh || exit 1
$CI TAG=$tag_to_use ./build.sh || exit 1
popd
pushd JeMPI_ETL
CI=true TAG=$tag_to_use ./build.sh || exit 1
$CI TAG=$tag_to_use ./build.sh || exit 1
popd
pushd JeMPI_Controller
CI=true TAG=$tag_to_use ./build.sh || exit 1
$CI TAG=$tag_to_use ./build.sh || exit 1
popd
pushd JeMPI_EM_Scala
CI=true TAG=$tag_to_use ./build.sh || exit 1
$CI TAG=$tag_to_use ./build.sh || exit 1
popd
pushd JeMPI_Linker
CI=true TAG=$tag_to_use ./build.sh || exit 1
$CI TAG=$tag_to_use ./build.sh || exit 1
popd
pushd JeMPI_API
CI=true TAG=$tag_to_use ./build.sh || exit 1
$CI TAG=$tag_to_use ./build.sh || exit 1
popd
pushd JeMPI_API_KC
CI=true TAG=$tag_to_use ./build.sh || exit 1
$CI TAG=$tag_to_use ./build.sh || exit 1
popd
pushd JeMPI_Bootstrapper
CI=true TAG=$tag_to_use ./build.sh || exit 1
$CI TAG=$tag_to_use ./build.sh || exit 1
popd
pushd JeMPI_UI
CI=true TAG=$tag_to_use ./build-image.sh || exit 1
$CI TAG=$tag_to_use ./build-image.sh || exit 1
popd
22 changes: 14 additions & 8 deletions JeMPI_Apps/build-all-java.sh
View file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sushantpatil1214 If we hardcode the CI flag like this, wouldn't that cause issues with other flows, like Platform / CI flows? Thinking it might be better to declare it once at the top of the file and check if it's set? For example:

CI=${CI:-false}
if [ $# -eq 0 ]; then
    tag_to_use="ci-test-main" 
else
    tag_to_use=$1
fi

Copy link
Collaborator Author

@sushantpatil1214 sushantpatil1214 Jul 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martino-jembi
Already same hard-coded inbuild-all-ci.shfile. I don't think it will impact.
But it sounds good to me.

Original file line number Diff line number Diff line change
@@ -6,34 +6,40 @@ set -u
cp -L -f ./JeMPI_Configuration/config-api.json ./JeMPI_API/src/main/resources/config-api.json
cp -L -f ./JeMPI_Configuration/config-api.json ./JeMPI_API_KC/src/main/resources/config-api.json

CI=${CI:-false}
if [ $# -eq 0 ]; then
tag_to_use="ci-test-main"
else
tag_to_use=$1
fi
mvn clean package
pushd JeMPI_EM_Scala
sbt clean assembly
popd

pushd JeMPI_AsyncReceiver
./build.sh || exit 1
$CI TAG=$tag_to_use ./build.sh || exit 1
popd
pushd JeMPI_ETL
./build.sh || exit 1
$CI TAG=$tag_to_use ./build.sh || exit 1
popd
pushd JeMPI_Controller
./build.sh || exit 1
$CI TAG=$tag_to_use ./build.sh || exit 1
popd
pushd JeMPI_EM_Scala
./build.sh || exit 1
$CI TAG=$tag_to_use ./build.sh || exit 1
popd
pushd JeMPI_Linker
./build.sh || exit 1
$CI TAG=$tag_to_use ./build.sh || exit 1
popd
pushd JeMPI_API
./build.sh || exit 1
$CI TAG=$tag_to_use ./build.sh || exit 1
popd
pushd JeMPI_API_KC
./build.sh || exit 1
$CI TAG=$tag_to_use ./build.sh || exit 1
popd
pushd JeMPI_Bootstrapper
./build.sh || exit 1
$CI TAG=$tag_to_use ./build.sh || exit 1
popd
pushd JeMPI_AsyncReceiver
./push.sh
7 changes: 6 additions & 1 deletion JeMPI_Apps/build-all-ui.sh
View file
Original file line number Diff line number Diff line change
@@ -2,9 +2,14 @@

set -e
set -u
if [ $# -eq 0 ]; then
tag_to_use="ci-test-main"
else
tag_to_use=$1
fi

pushd JeMPI_UI
./build-image.sh || exit 1
CI=false TAG=$tag_to_use ./build-image.sh || exit 1
popd

pushd JeMPI_UI