StashBuildTrigger: Rename StashBuildTriggerDescriptor to DescriptorImpl #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
proski
force-pushed
the
rename-descriptor
branch
from
81cabdd to
cc3ca2a
Compare
Don't we need a data migration then? |
|
We don't have any data to migrate because we don't have any global settings yet. I actually tried upgrading from the master branch to this PR, there are no messages about unreadable data. The goal is to have global setting use the shorter and idiomatic name from the beginning. That way we avoid data migration in the future. |
DescriptorImpl is the standard name for a descriptor defined as an inner class. StashBuildTriggerDescriptor is a long name that duplicates the name of its containing class, StashBuildTrigger.
proski
force-pushed
the
rename-descriptor
branch
from
cc3ca2a to
6584ab3
Compare
OK, I was worried the empty descriptor would still generate warnings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually,
StashPostBuildComment.javausesDescriptorImpl, so the plugin code is inconsistent. Let's make it consistent.The descriptor name is written to the XML file that holds the global configuration of the plugin. That's where the option to enable pipelines would go. That's why I want this PR to be merged before #69 so that we don't deal with backward compatibility later.