Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update collection.js #3384

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update collection.js #3384

wants to merge 1 commit into from

Conversation

0xDS
Copy link

@0xDS 0xDS commented Feb 11, 2025

Replaced array.map with a for loop to improve performance

Replaced array.map with a for loop to improve performance
@gwhitney
Copy link
Collaborator

It appears that deepMap is already undergoing tuning by @dvd101x and @josdejong. What is the relationship between this and #3266? I would not want to embark on reviewing this without their input.

@dvd101x
Copy link
Collaborator

dvd101x commented Feb 12, 2025

#3266 addresses these issues and others. Maybe it's becoming to big.

Seeing this PR I think it might be better to reduce #3266 so that it can be implemented easily to avoid further conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants