Skip to content

Update collection.js #3384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/utils/collection.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,21 @@
*
* @return {Array | Matrix} res
*/
export function deepMap (array, callback, skipZeros) {
if (array && (typeof array.map === 'function')) {
// TODO: replace array.map with a for loop to improve performance
return array.map(function (x) {
return deepMap(x, callback, skipZeros)
})
} else {
return callback(array)
export function deepMap(array, callback, skipZeros) {

Check failure on line 56 in src/utils/collection.js

View workflow job for this annotation

GitHub Actions / lint

Missing space before function parentheses
const result = [];

Check failure on line 57 in src/utils/collection.js

View workflow job for this annotation

GitHub Actions / lint

Extra semicolon
for (let i = 0; i < array.length; i++) {
const value = array[i];

Check failure on line 59 in src/utils/collection.js

View workflow job for this annotation

GitHub Actions / lint

Extra semicolon
if (Array.isArray(value)) {
result.push(deepMap(value, callback, skipZeros));

Check failure on line 61 in src/utils/collection.js

View workflow job for this annotation

GitHub Actions / lint

Extra semicolon
} else {
if (!skipZeros || value !== 0) {
result.push(callback(value));

Check failure on line 64 in src/utils/collection.js

View workflow job for this annotation

GitHub Actions / lint

Extra semicolon
} else {
result.push(value);

Check failure on line 66 in src/utils/collection.js

View workflow job for this annotation

GitHub Actions / lint

Extra semicolon
}
}
}
return result;

Check failure on line 70 in src/utils/collection.js

View workflow job for this annotation

GitHub Actions / lint

Extra semicolon
}

/**
Expand Down
Loading