Copy static assets to legacy paths for notebook 6 compatibility #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RRosio
added
bug
danyeaw
reviewed
Sep 12, 2025
package.json
Outdated
| }, | ||
| "engines": { | ||
| "yarn": "^1.22.22", | ||
| "node": ">=16" |
There was a problem hiding this comment.
Should we update the node engine version as well?
danyeaw
approved these changes
Sep 12, 2025
|
Thanks Dan for the review, I implemented those changes and will go ahead and start a new release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the CopyWebpackPlugin to copy the static assets from their new paths to the legacy paths of classic jupyter notebook 6.