Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introducing hyperswitch_interface crates #3536

Merged
merged 22 commits into from
Feb 12, 2024

Conversation

Chethan-rao
Copy link
Contributor

@Chethan-rao Chethan-rao commented Feb 2, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Create a new crate Hyperswitch-interface containing below modules for now:
secrets_interface: Module used for application config encryption and decryption during startup which will contain its own trait and error types
encryption_interface: Module used for user value encryption and decryption during runtime which will contain its own trait and error types

This PR only adds the above crate with the addition of secret_management_config and encryption_management_config in the router

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

New crates addition which doesn't integrate with other existing crates yet. So basic sanity testing should suffice

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Chethan-rao Chethan-rao added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-configuration-changes Metadata: This PR involves configuration changes C-refactor Category: Refactor labels Feb 2, 2024
@Chethan-rao Chethan-rao self-assigned this Feb 2, 2024
@Chethan-rao Chethan-rao requested a review from a team as a code owner February 2, 2024 13:02
@Chethan-rao Chethan-rao force-pushed the secrets-interface-crate branch from 5d7a66e to 54f09c6 Compare February 2, 2024 13:09
@Chethan-rao Chethan-rao linked an issue Feb 2, 2024 that may be closed by this pull request
@Chethan-rao Chethan-rao force-pushed the secrets-interface-crate branch from 20ab467 to de4999a Compare February 5, 2024 17:10
@Chethan-rao Chethan-rao changed the title refactor: introducing secrets_interface and encryption_interface crates refactor: introducing hyperswitch_interface crates Feb 9, 2024
jarnura
jarnura previously approved these changes Feb 9, 2024
@Chethan-rao Chethan-rao force-pushed the secrets-interface-crate branch from a6036e0 to 372cbc1 Compare February 9, 2024 11:37
SanchithHegde
SanchithHegde previously approved these changes Feb 9, 2024
@likhinbopanna likhinbopanna removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 12, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Feb 12, 2024
Merged via the queue into main with commit b6754a7 Feb 12, 2024
10 of 12 checks passed
@likhinbopanna likhinbopanna deleted the secrets-interface-crate branch February 12, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-refactor Category: Refactor M-configuration-changes Metadata: This PR involves configuration changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] introducing hyperswitch_interface crates
4 participants