-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: introducing hyperswitch_interface
crates
#3536
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d7a66e
to
54f09c6
Compare
20ab467
to
de4999a
Compare
jarnura
requested changes
Feb 9, 2024
secrets_interface
and encryption_interface
crateshyperswitch_interface
crates
jarnura
previously approved these changes
Feb 9, 2024
…ch into secrets-interface-crate
a6036e0
to
372cbc1
Compare
SanchithHegde
previously approved these changes
Feb 9, 2024
…ch into secrets-interface-crate
SanchithHegde
approved these changes
Feb 11, 2024
jarnura
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-refactor
Category: Refactor
M-configuration-changes
Metadata: This PR involves configuration changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Create a new crate
Hyperswitch-interface
containing below modules for now:secrets_interface
: Module used for application configencryption
anddecryption
during startup which will contain its own trait and error typesencryption_interface
: Module used for user valueencryption
anddecryption
during runtime which will contain its own trait and error typesThis PR only adds the above crate with the addition of
secret_management_config
andencryption_management_config
in therouter
Additional Changes
Motivation and Context
How did you test it?
New crates addition which doesn't integrate with other existing crates yet. So basic sanity testing should suffice
Checklist
cargo +nightly fmt --all
cargo clippy