Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information in debugging k3po.js in readme, #3

Merged
merged 1 commit into from
Feb 29, 2016

Conversation

dpwspoon
Copy link
Member

& added some extra logging in the browser for when debugging was enabled.

@AdrianCozma Thanks for reporting the issue. The bug was simply that the script executing did not close the WebSocket connection. So the onclose callback with done was never called until k3po and the test was already terminated. I figure this out but launching with the debug flag and looking at the browser console log after it ran. At first I did not think there was enough logging so I added some more when the debug flag is added. Then I noticed the onclose / done was being called after test completion.

As per k3po it self. We should be able to programmatically increase the logging on k3po when it starts. In maven we do that with a -X. In the grunt-k3po plugin we call maven from javascript but we don't expose a way to do that. we should. I've filed this issue for it: k3po/grunt-k3po#5. It should be fairly straight forward if you want to have a look at it: k3po/grunt-k3po#5.

With out that flag you need to wireshark the k3po control protocol. That was what I was going to have you do in our call this morning but figured it would be easier to look to see if there was a debug flag. This was to find out if the script was completing all the way. As per the test failure, we saw a timeout but no script diff. This indicated that the test timeout but that the script returned with completion. Just FYI.

Thanks, hope this works for you. Everything is passing on my machine now. As always feel free to ping me if you have more questions

…the browser for when debugging was enabled
@AdrianCozma
Copy link

Thanks for the debugging info @dpwspoon. the tests pass now both locally and on SauceLabs(though they take quite a long time, about 10s each, maybe it's because of slow communication between my machine and saucelabs).

@AdrianCozma
Copy link

@dpwspoon any idea why the travis build is failing?(could it be related to the node.js version on the travis vm?)

@dpwspoon dpwspoon merged commit 170693c into k3po:develop Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants