Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reconciler list only looping k8sgpt`s results #357

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

JuHyung-Son
Copy link
Contributor

@JuHyung-Son JuHyung-Son commented Feb 26, 2024

Closes #356

📑 Description

since prev latestResultList lists all k8sgpt's result, not just looping one. it gets all result.
so i added MatchingLabel so that it lists only looping k8sgpt config's result

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@JuHyung-Son JuHyung-Son requested review from a team as code owners February 26, 2024 09:42
Copy link
Member

@arbreezy arbreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@AlexsJones AlexsJones merged commit a45b473 into k8sgpt-ai:main Feb 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: multi cluster monitoring sends same slack message with difference cluster name
3 participants