Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reconciler list only looping k8sgpt`s results #357

Merged
merged 2 commits into from
Feb 27, 2024
Merged

fix reconciler list only looping k8sgpt`s results #357

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
873d755
fix reconciler list only looping k8sgpt`s results
JuHyung-Son Feb 26, 2024
58f40bb
Merge branch 'main' into issue-356
AlexsJones Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion controllers/k8sgpt_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,10 @@ func (r *K8sGPTReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
// We emit when result Status is not historical
// and when user configures a sink for the first time
latestResultList := &corev1alpha1.ResultList{}
if err := r.List(ctx, latestResultList); err != nil {
if err := r.List(ctx, latestResultList, client.MatchingLabels(map[string]string{
"k8sgpts.k8sgpt.ai/name": k8sgptConfig.Name,
"k8sgpts.k8sgpt.ai/namespace": k8sgptConfig.Namespace,
})); err != nil {
return r.finishReconcile(err, false)
}
if len(latestResultList.Items) == 0 {
Expand Down
Loading