Added tests pkg/util/fedinformer #5366
Conversation
karmada-bot
added
kind/failing-test
karmada-bot
added
the
size/L
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5366 +/- ##
==========================================
+ Coverage 29.01% 30.26% +1.24%
==========================================
Files 632 632
Lines 43862 43936 +74
==========================================
+ Hits 12728 13297 +569
+ Misses 30218 29676 -542
- Partials 916 963 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/assign |
|
@XiShanYongYe-Chang PTAL |
|
Hi @anujagrawal699 would you like to review the ut tests submitted by others? It's not mandatory, you can do it as you wish, and it's an important contribution to the community. Thank you very much! |
Yeah, i would really love to review the UT tests. But how can i get started with it? I haven't done such things before. |
|
Make a refer here: #5390 (comment) I gave everyone the same advice. It wasn't stated in a public place, so I'll use the link instead. |
|
@XiShanYongYe-Chang PTAL |
|
Can you help squash the commits into one? |
Can you guide me through it? |
You can try with this: https://poe.com/s/3VOKcFAMUerETxS3aY0n |
anujagrawal699
force-pushed
the
addedTests-pkg/util/fedinformer
branch
from
b2f37bc to
690581a
Compare
@XiShanYongYe-Chang Thanks. Done! |
karmada-bot
added
size/XL
|
@XiShanYongYe-Chang Could you retest? |
Hi @anujagrawal699. you can squash the commits and push it again. |
anujagrawal699
force-pushed
the
addedTests-pkg/util/fedinformer
branch
from
8b837fc to
8f85504
Compare
@XiShanYongYe-Chang Done. |
Signed-off-by: Anuj Agrawal <[email protected]> Added tests for pkg/util/fedinformer Signed-off-by: Anuj Agrawal <[email protected]> Added tests for pkg/util/fedinformer Signed-off-by: Anuj Agrawal <[email protected]> Added tests for pkg/util/fedinformer Signed-off-by: Anuj Agrawal <[email protected]> Added tests for pkg/util/fedinformer Signed-off-by: Anuj Agrawal <[email protected]>
anujagrawal699
force-pushed
the
addedTests-pkg/util/fedinformer
branch
from
8f85504 to
daf29c5
Compare
|
@XiShanYongYe-Chang PTAL. |
|
@XiShanYongYe-Chang Can you please review? |
|
Thanks a lot |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Description:
This PR adds 3 new test files for pkg/util/fedinformer and enhances its code coverage and reliability of a critical component of the project. These new additions have increased its test coverage significantly.
Additions:
3 new test files are implemented in this PR.
What type of PR is this?
/kind failing-test
/kind feature
What this PR does / why we need it:
This PR improves the test coverage and reliability of the fedinformer package, which is critical for the functionality of the project. Enhanced testing ensures better stability and performance.
Which issue(s) this PR fixes:
Fixes a part of #5235
Does this PR introduce a user-facing change?: