pkg/webhook: unit test cluster propagation policy #5494
Conversation
karmada-bot
added
kind/failing-test
karmada-bot
added
the
size/L
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5494 +/- ##
==========================================
+ Coverage 31.70% 33.97% +2.27%
==========================================
Files 643 643
Lines 44445 44509 +64
==========================================
+ Hits 14090 15122 +1032
+ Misses 29325 28236 -1089
- Partials 1030 1151 +121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mohamedawnallah
force-pushed
the
unitTestClusterPropagationPolicy
branch
from
9ee6c54 to
e601852
Compare
|
Closing and reopening some flaky e2e failures... |
mohamedawnallah
force-pushed
the
unitTestClusterPropagationPolicy
branch
from
e601852 to
0acbdf8
Compare
In this commit, we introduce unit tests for both the `ValidatingAdmission` and `MutatingAdmission` webhooks for the `ClusterPropagationPolicy` resource. The tests include: - Validation webhook tests: - Tests how the webhook responds when decoding the request object fails. - Ensures updates to the `SchedulerName` field are denied, as it should remain immutable. - Validates that changes to the `ClusterPropagationPolicyPermanentIDLabel` label and its absence in creation requests are correctly handled. - Confirms that valid `ClusterPropagationPolicy` objects are allowed through without errors. - Mutation webhook tests: - Handles decode errors and denies admission when decoding fails. - Provides full coverage of cluster policy mutation with default values and patch application. Signed-off-by: Mohamed Awnallah <[email protected]>
mohamedawnallah
force-pushed
the
unitTestClusterPropagationPolicy
branch
from
0acbdf8 to
8795864
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Description
In this commit, we introduce unit tests for both the
ValidatingAdmissionandMutatingAdmissionwebhooks for theClusterPropagationPolicyresource.The tests include:
Validation webhook tests:
SchedulerNamefield are denied, as it should remain immutable.ClusterPropagationPolicyPermanentIDLabellabel and its absence in creation requests are correctly handled.ClusterPropagationPolicyobjects are allowed through without errors.Mutation webhook tests:
What type of PR is this?
/kind failing-test
/kind feature
Which issue(s) this PR fixes:
Part of #5491
Does this PR introduce a user-facing change?: