Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify http ratelimiter #6095

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

zach593
Copy link
Contributor

@zach593 zach593 commented Feb 4, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #6094

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

For all components that have ratelimit parameters for `cluster-api-qps`, `cluster-api-burst`, `kube-api-qps`, and `kube-api-burst`, these parameters will work more strictly, so administrators may need to adjust them to get the same effect as before the update.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 40.69767% with 51 lines in your changes missing coverage. Please review.

Project coverage is 48.09%. Comparing base (ae2d1c1) to head (7fa65cf).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/util/membercluster_client.go 12.50% 10 Missing and 4 partials ⚠️
cmd/controller-manager/app/controllermanager.go 0.00% 11 Missing ⚠️
cmd/agent/app/agent.go 0.00% 7 Missing ⚠️
cmd/metrics-adapter/app/options/options.go 0.00% 3 Missing ⚠️
pkg/metricsadapter/controller.go 0.00% 3 Missing ⚠️
pkg/metricsadapter/multiclient/client.go 0.00% 3 Missing ⚠️
cmd/aggregated-apiserver/app/options/options.go 0.00% 1 Missing ⚠️
cmd/descheduler/app/descheduler.go 0.00% 1 Missing ⚠️
cmd/karmada-search/app/karmada-search.go 0.00% 1 Missing ⚠️
cmd/scheduler-estimator/app/scheduler-estimator.go 0.00% 1 Missing ⚠️
... and 6 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6095      +/-   ##
==========================================
- Coverage   48.10%   48.09%   -0.02%     
==========================================
  Files         668      669       +1     
  Lines       55163    55206      +43     
==========================================
+ Hits        26536    26551      +15     
- Misses      26900    26923      +23     
- Partials     1727     1732       +5     
Flag Coverage Δ
unittests 48.09% <40.69%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot~

The PR looks a little big. Can it be split, for example, cluster or karmada, or different components?

In addition, are there any modified test results?

pkg/util/ratelimiter.go Outdated Show resolved Hide resolved
limitations under the License.
*/

package util
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help add some ut for this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

Signed-off-by: zach593 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http rate limit parameters not working properly
4 participants