-
Notifications
You must be signed in to change notification settings - Fork 32
Fix and improve for local deployment #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix and improve for local deployment #1102
Conversation
06e042e
to
c9fc75f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to reproduce bug this patch (rename timeout) is fixing?
Rename timeout patch fixes:
Environment:
|
c9fc75f
to
5030564
Compare
What about something like this? I removed obsolete Dockerfiles. I will open another PR in deployment to add missing container builds. |
I will need to check if renaming will cause any issues with existing deployment scripts, it might take a bit of time, but likely will do this week. |
Edit: apparently the |
Probably this PR causes breakage at staging script
|
You're right @nuclearcat , since this PR merges pipeline-lava-callback, pipeline-kcidb and all other pipeline services in one compose file in 03042de, Not sure but maybe upgrading to the new |
d9882c7
to
24ea02e
Compare
https://github.com/kernelci/kernelci-core/actions/runs/14589446598/job/40921114087
|
I think you need to rebase your patch |
ce5cbf1
to
78a84a1
Compare
Done, this should work, thanks @nuclearcat ! |
Signed-off-by: Simone Tollardo <[email protected]>
… with docker keyword Signed-off-by: Simone Tollardo <[email protected]>
Signed-off-by: Simone Tollardo <[email protected]>
Signed-off-by: Simone Tollardo <[email protected]>
…ces, remove useless volume mount Signed-off-by: Simone Tollardo <[email protected]>
Signed-off-by: Simone Tollardo <[email protected]>
Signed-off-by: Simone Tollardo <[email protected]>
Signed-off-by: Simone Tollardo <[email protected]>
Signed-off-by: Simone Tollardo <[email protected]>
…onflicts with docker keyword" This reverts commit 5030564. Signed-off-by: Simone Tollardo <[email protected]>
78a84a1
to
6253e95
Compare
This PR aims to fix and improve containers for local deployments by:
./kci docker
)This PR is tightly related to recent fixes and improvements I am proposing in
kernelci/kernelci-deploy
.