test(wasi): enable absolute symlink tests#97
Draft
kkebo wants to merge 3 commits into
Draft
Conversation
cb0d434 to
bdeb322
Compare
ea10895 to
dee2289
Compare
Owner
Author
|
Features we need:
Runtimes comparison:
Related issues: |
9487f1b to
cb531a7
Compare
Owner
Author
|
I'm going to create another PR #116 to enable relative symlink tests while leaving absolute symlink tests disabled. This PR will focus on absolute symlink tests. |
cb531a7 to
1c57532
Compare
This was referenced Aug 7, 2025
1c57532 to
5447da0
Compare
d9af3b7 to
956adb7
Compare
956adb7 to
2ab2893
Compare
Owner
Author
|
I've confirmed that all tests successfully passed when executed on the latest WasmKit. 🎉 |
1f3b89a to
04668c6
Compare
Owner
Author
|
Now the diff --git a/Tests/SwiftFormatTests/Utilities/FileIteratorTests.swift b/Tests/SwiftFormatTests/Utilities/FileIteratorTests.swift
index 1727c52..3c70593 100644
--- a/Tests/SwiftFormatTests/Utilities/FileIteratorTests.swift
+++ b/Tests/SwiftFormatTests/Utilities/FileIteratorTests.swift
@@ -69,6 +69,12 @@ final class FileIteratorTests: XCTestCase {
}
override func tearDownWithError() throws {
+ #if os(WASI) // https://github.com/swiftlang/swift-foundation/pull/1786
+ let iter = FileManager.default.enumerator(at: tmpdir, includingPropertiesForKeys: nil)!
+ for url in iter.reversed().compactMap({ $0 as? URL }) {
+ try FileManager.default.removeItem(at: url)
+ }
+ #endif
try FileManager.default.removeItem(at: tmpdir)
} |
04668c6 to
b95c581
Compare
Owner
Author
|
This PR should revert 3725ed5 too. |
b95c581 to
0bdb431
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.