Skip to content

test(wasi): enable absolute symlink tests #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kkebo wants to merge 3 commits into
base: wasm32-wasi
Choose a base branch
from
Draft

test(wasi): enable absolute symlink tests #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f184a4a
test(wasi): enable absolute symlink tests
kkebo Oct 3, 2024
a720919
test(wasi): remove unnecessary workaround
kkebo Mar 3, 2026
0bdb431
revert: test: do not use absolute symlink
kkebo May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions Tests/SwiftFormatTests/Utilities/FileIteratorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,19 +54,13 @@ final class FileIteratorTests: XCTestCase {
try touch("project/real2.swift")
try touch("project/.hidden.swift")
try touch("project/.build/generated.swift")
#if !os(WASI) // FIXME: Remove this #if
try symlink("project/link.swift", to: "project/.hidden.swift")
#endif
try symlink("project/rellink.swift", relativeTo: ".hidden.swift")

#if !(os(Windows) && compiler(<5.10))
// Test both a self-cycle and a cycle between multiple symlinks.
try symlink("project/cycliclink.swift", relativeTo: "cycliclink.swift")
#if !os(WASI)
try symlink("project/linktolink.swift", relativeTo: "link.swift")
#else
try symlink("project/linktolink.swift", relativeTo: "rellink.swift")
#endif

// Test symlinks that use nonstandardized paths.
try symlink("project/2stepcyclebegin.swift", relativeTo: "../project/2stepcycleend.swift")
Expand Down Expand Up @@ -121,7 +115,6 @@ final class FileIteratorTests: XCTestCase {
tmpURL("project/cycliclink.swift"),
tmpURL("project/2stepcyclebegin.swift"),
tmpURL("project/link.swift"),
tmpURL("project/rellink.swift"),
],
followSymlinks: true
)
Expand Down
7 changes: 0 additions & 7 deletions Tests/SwiftFormatTests/Utilities/IgnoreEdgeCaseTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,14 +158,7 @@ struct IgnoreEdgeCaseTests {

// Create a symlink to the real file
let symlinkFile = testDir.appendingPathComponent("SymlinkFile.swift")
#if os(WASI)
try FileManager.default.createSymbolicLink(
atPath: symlinkFile.path(percentEncoded: false),
withDestinationPath: "RealFile.swift"
)
#else
try FileManager.default.createSymbolicLink(at: symlinkFile, withDestinationURL: realFile)
#endif

// Create ignore file that ignores symlinks
let ignoreFile = testDir.appendingPathComponent(".swift-format-ignore")
Expand Down
Loading