-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug causing large asynchronous translations to fail #5059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…large-auto-translation-fix
…atures on submission extras django kobo app
… large-auto-translation-fix
noliveleger
requested changes
Aug 15, 2024
kobo/apps/subsequences/integrations/google/google_transcribe.py
Outdated
Show resolved
Hide resolved
noliveleger
reviewed
Aug 16, 2024
noliveleger
reviewed
Aug 16, 2024
kobo/apps/subsequences/integrations/google/google_transcribe.py
Outdated
Show resolved
Hide resolved
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the backend to handle large (async) translations using google cloud integration
Notes
This includes a lot of refactoring of old code as well as deleting some old code that is not being used anywhere on the code base. There is still one class that I don't know yet if it'll be used. Further discussion to delete it is needed. This integration was tested for all 4 cases: sync/async and transcriptions/translations.
Related issues
Fixes Notion task 709