-
-
Notifications
You must be signed in to change notification settings - Fork 366
chore: update justfile #1842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: update justfile #1842
Conversation
Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1842 +/- ##
=======================================
- Coverage 74.6% 74.6% -0.0%
=======================================
Files 84 84
Lines 7910 7910
=======================================
- Hits 5900 5897 -3
- Misses 2010 2013 +3
🚀 New features to boost your workflow:
|
|
Ah, thanks for starting this. The main parts here will work, but the docker part will not because you ran into my other landmine from #1843 We need to also change the in-cluster dockerbuild to not use the image where i explicitly removed openssl. |
Gotcha. Do you think this PR stands on its own and we can follow-up by resolving #1843 and the custom image issue (does that have an issue yet? If not I suppose we can make it). What is your preference in terms of next steps? |
yeah, this PR probably stands on its own. If only the in-cluster jobs here are failing we can merge this. All other tests pass. There are some inconsistencies with rustfmt in ci vs local. ..i updated your branch and now the in-cluster ones are actually working again thanks to a different PR #1840 which avoids bumping the rust version (and CI does not actually bump the rust version atm, this pr only changes the justfile). if you updated the workflow to match it will probably start failing again. maybe this PR removes the need to bump it the minimum rustc as part of this PR? |
clux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small problem
Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
Updates CI to rust 2024 edition rustfmt, and rustc 1.91.0.