Skip to content

Conversation

@shaneutt
Copy link
Member

@shaneutt shaneutt commented Oct 31, 2025

Updates CI to rust 2024 edition rustfmt, and rustc 1.91.0.

@shaneutt shaneutt changed the title chore: update justfile calls for 2024 edition chore: update justfile Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.6%. Comparing base (b14f3d7) to head (c7eb2ab).

Files with missing lines Patch % Lines
kube-core/src/schema.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1842     +/-   ##
=======================================
- Coverage   74.6%   74.6%   -0.0%     
=======================================
  Files         84      84             
  Lines       7910    7910             
=======================================
- Hits        5900    5897      -3     
- Misses      2010    2013      +3     
Files with missing lines Coverage Δ
kube-core/src/schema.rs 95.2% <0.0%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clux
Copy link
Member

clux commented Nov 3, 2025

Ah, thanks for starting this. The main parts here will work, but the docker part will not because you ran into my other landmine from #1843

We need to also change the in-cluster dockerbuild to not use the image where i explicitly removed openssl.

@shaneutt
Copy link
Member Author

shaneutt commented Nov 3, 2025

Ah, thanks for starting this. The main parts here will work, but the docker part will not because you ran into my other landmine from #1843

We need to also change the in-cluster dockerbuild to not use the image where i explicitly removed openssl.

Gotcha. Do you think this PR stands on its own and we can follow-up by resolving #1843 and the custom image issue (does that have an issue yet? If not I suppose we can make it). What is your preference in terms of next steps?

@clux
Copy link
Member

clux commented Nov 3, 2025

Gotcha. Do you think this PR stands on its own and we can follow-up by resolving #1843 and the custom image issue (does that have an issue yet? If not I suppose we can make it). What is your preference in terms of next steps?

yeah, this PR probably stands on its own. If only the in-cluster jobs here are failing we can merge this. All other tests pass. There are some inconsistencies with rustfmt in ci vs local.

..i updated your branch and now the in-cluster ones are actually working again thanks to a different PR #1840 which avoids bumping the rust version (and CI does not actually bump the rust version atm, this pr only changes the justfile). if you updated the workflow to match it will probably start failing again. maybe this PR removes the need to bump it the minimum rustc as part of this PR?

@shaneutt shaneutt marked this pull request as ready for review November 3, 2025 20:43
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small problem

@shaneutt shaneutt requested a review from clux November 4, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants