-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(chart): add support for specifying --default-load-balancer-scheme flag #4141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(chart): add support for specifying --default-load-balancer-scheme flag #4141
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ysam12345 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @ysam12345. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Conflic with dbe9af8 I really don't know why this commit changed so many lines in |
5ad597e
to
beec141
Compare
/lgtm Thanks for this chart addition! |
/lgtm |
Issue
#4085
Description
Add support for specifying
--default-load-balancer-scheme
(command line parameter) in helm.Checklist
README.md
, or thedocs
directory)internal
,internet-facing
and not specifying the helm value fordefaultLoadBalancerScheme
.BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯