Skip to content

feat(chart): add support for specifying --default-load-balancer-scheme flag #4141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(chart): add support for specifying --default-load-balancer-scheme flag #4141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions helm/aws-load-balancer-controller/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ The default values set by the application itself can be confirmed [here](https:/
| `awsApiThrottle` | Custom AWS API throttle settings | None |
| `awsMaxRetries` | Maximum retries for AWS APIs | None |
| `defaultTargetType` | Default target type. Used as the default value of the `alb.ingress.kubernetes.io/target-type` and `service.beta.kubernetes.io/aws-load-balancer-nlb-target-type" annotations.`Possible values are `ip` and `instance`. | `instance` |
| `defaultLoadBalancerScheme` | Default scheme for ELBs. Possible values are `internal` and `internet-facing`. When not specifying, an `internal` ELB will be created by default. | "" |
| `enablePodReadinessGateInject` | If enabled, targetHealth readiness gate will get injected to the pod spec for the matching endpoint pods | None |
| `enableShield` | Enable Shield addon for ALB | None |
| `enableWaf` | Enable WAF addon for ALB | None |
Expand Down
3 changes: 3 additions & 0 deletions helm/aws-load-balancer-controller/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,9 @@ spec:
{{- if ne .Values.defaultTargetType "instance" }}
- --default-target-type={{ .Values.defaultTargetType }}
{{- end }}
{{- if .Values.defaultLoadBalancerScheme }}
- --default-load-balancer-scheme={{ .Values.defaultLoadBalancerScheme }}
{{- end }}
{{- if .Values.serviceTargetENISGTags }}
- --service-target-eni-security-group-tags={{ .Values.serviceTargetENISGTags }}
{{- end }}
Expand Down
6 changes: 4 additions & 2 deletions helm/aws-load-balancer-controller/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,10 @@ awsApiThrottle:
# Maximum retries for AWS APIs (default 10)
awsMaxRetries:



# Default load balancer scheme when not specifying "alb.ingress.kubernetes.io/scheme" or
# "service.beta.kubernetes.io/aws-load-balancer-scheme" annotations.
# Possible values are "internal" and "internet-facing" (default "internal")
defaultLoadBalancerScheme:

# If enabled, targetHealth readiness gate will get injected to the pod spec for the matching endpoint pods (default true)
enablePodReadinessGateInject:
Expand Down
5 changes: 5 additions & 0 deletions helm/aws-load-balancer-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,11 @@ awsMaxRetries:
# Cilium with masquerading enabled.
defaultTargetType: instance

# Default load balancer scheme when not specifying "alb.ingress.kubernetes.io/scheme" or
# "service.beta.kubernetes.io/aws-load-balancer-scheme" annotations.
# Possible values are "internal" and "internet-facing" (default "internal")
defaultLoadBalancerScheme:

# If enabled, targetHealth readiness gate will get injected to the pod spec for the matching endpoint pods (default true)
enablePodReadinessGateInject:

Expand Down
Loading