-
Notifications
You must be signed in to change notification settings - Fork 69
docs: add concepts and defs to README.md #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add concepts and defs to README.md #680
Conversation
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
6d24bda
to
cb449a5
Compare
28cd946
to
80cdfe1
Compare
18afde6
to
2a59553
Compare
2a59553
to
d305093
Compare
d305093
to
5fbb16d
Compare
Yeah! I think this looks great also, I'll apply all approval labels + a hold to give a chance to take a look at the nit/submit on your own terms. But if you're ready to merge just pull the hold off. Thanks for taking the time and care to enrich our landing page! Laying some ground definitions makes a lot of sense. /lgtm |
/lgtm |
77a2a20
to
9925a1c
Compare
36740ef
to
761c992
Compare
2030338
to
839d74c
Compare
Signed-off-by: Shane Utt <[email protected]>
839d74c
to
b18bd63
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I would unhold and ship it, but will leave it as I don't want to stomp on any discussion being had. Thanks @shaneutt!! |
New changes are detected. LGTM label has been removed. |
Could you help me please to better understand how precisely you're hoping for this to be incorporated? In particular, suggestion comments with explicit suggestions about changes would be ideal because they don't leave any room for misinterpretation. |
@shaneutt IMHO, we should consider leveraging each term and associated definition from https://cloud.google.com/kubernetes-engine/docs/concepts/machine-learning/inference#terminology. |
Github seems to be unable to track my branch at the moment, after my fork moved, so I'm going to re-create. |
This adds some potential helpful concepts and definitions for newcomers to the repository and the community.