-
Notifications
You must be signed in to change notification settings - Fork 40
Resolves: MTV-3743 | Standardize edit forklift settings #2111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Aviv Turgeman <[email protected]>
|
Wait for #2106 to be merged first |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2111 +/- ##
==========================================
- Coverage 36.81% 6.81% -30.00%
==========================================
Files 158 1014 +856
Lines 2548 19679 +17131
Branches 599 3923 +3324
==========================================
+ Hits 938 1341 +403
- Misses 1428 18332 +16904
+ Partials 182 6 -176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Aviv Turgeman <[email protected]>
64a4db6 to
ab11ab7
Compare
|
|
Looks good! Just a few things:
Potentially open a second PR for this if you want to keep the scope of this one simple but: Also tagging @heyethankim in case you want to review this too since it's your settings page :) |



📝 Links
https://issues.redhat.com/browse/MTV-3743
📝 Description
🎥 Demo
edit-settings.mp4
📝 CC://
@mmenestr please review