Skip to content

Commit

Permalink
fix(FR-546): handle session rename error of modify_compute_session
Browse files Browse the repository at this point in the history
  • Loading branch information
yomybaby committed Feb 18, 2025
1 parent 9b5b7b2 commit 45cc40d
Show file tree
Hide file tree
Showing 22 changed files with 62 additions and 26 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { useCurrentUserInfo } from '../../hooks/backendai';
import { getSessionNameRules } from '../SessionNameFormItem';
import { EditableSessionNameFragment$key } from './__generated__/EditableSessionNameFragment.graphql';
import { EditableSessionNameMutation } from './__generated__/EditableSessionNameMutation.graphql';
import { theme, Form, Input } from 'antd';
import { theme, Form, Input, App } from 'antd';
import Text, { TextProps } from 'antd/es/typography/Text';
import Title, { TitleProps } from 'antd/es/typography/Title';
import graphql from 'babel-plugin-relay/macro';
Expand Down Expand Up @@ -43,7 +43,7 @@ const EditableSessionName: React.FC<EditableSessionNameProps> = ({
const [commitEditMutation, isPendingEditMutation] =
useMutation<EditableSessionNameMutation>(graphql`
mutation EditableSessionNameMutation($input: ModifyComputeSessionInput!) {
modify_compute_session(input: $input) {
modify_compute_session(input: $input) @catch {
item {
id
name
Expand All @@ -55,6 +55,7 @@ const EditableSessionName: React.FC<EditableSessionNameProps> = ({
const { t } = useTranslation();
const { token } = theme.useToken();
const [isEditing, setIsEditing] = useState(false);
const { message } = App.useApp();

const isNotPreparingCategoryStatus = ![
'RESTARTING',
Expand Down Expand Up @@ -107,8 +108,23 @@ const EditableSessionName: React.FC<EditableSessionNameProps> = ({
name: values.sessionName,
},
},
onCompleted(response, errors) {},
onError(error) {},
onCompleted(response, errors) {
if (!response.modify_compute_session.ok) {
// With @catch directive, errors should be in response.modify_compute_session.errors
// However, it's empty, so we use errors from onCompleted instead
const errMessage = errors?.[0]?.message || '';
if (errMessage.includes('Duplicate session name.')) {
message.error(t('session.launcher.SessionAlreadyExists'));
} else {
if (errors?.[0]?.message) {
message.error(t('session.FailToRenameSession'));
}
}
}
},
onError(error) {
message.error(t('session.FailToRenameSession'));
},
});
}}
initialValues={{
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,8 @@
"ReadLess": "Weniger lesen",
"ReadMore": "Mehr lesen...",
"CommitImageName": "Festgeschriebener Bildname",
"IdleCheckExpirationWarning": "Sitzungen können basierend auf den Ergebnissen der Inaktivitätsprüfungen beendet werden."
"IdleCheckExpirationWarning": "Sitzungen können basierend auf den Ergebnissen der Inaktivitätsprüfungen beendet werden.",
"FailToRenameSession": "Die Anfrage zum Ändern des Sitzungsnamens ist fehlgeschlagen."
},
"button": {
"Cancel": "Stornieren",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/el.json
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,8 @@
"ReadLess": "Διαβάστε λιγότερα",
"ReadMore": "Διαβάστε Περισσότερα...",
"CommitImageName": "Όνομα δεσμευμένης εικόνας",
"IdleCheckExpirationWarning": "Οι συνεδρίες ενδέχεται να τερματιστούν με βάση τα αποτελέσματα των Ελέγχων αδράνειας."
"IdleCheckExpirationWarning": "Οι συνεδρίες ενδέχεται να τερματιστούν με βάση τα αποτελέσματα των Ελέγχων αδράνειας.",
"FailToRenameSession": "Η αίτηση αλλαγής του ονόματος συνεδρίας απέτυχε."
},
"button": {
"Cancel": "Ματαίωση",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,8 @@
"ReadLess": "Read less",
"ReadMore": "Read More...",
"CommitImageName": "Committed image name",
"IdleCheckExpirationWarning": "Sessions may be terminated based on the results of Idleness Checks."
"IdleCheckExpirationWarning": "Sessions may be terminated based on the results of Idleness Checks.",
"FailToRenameSession": "The session rename request failed."
},
"modelService": {
"Services": "Services",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -1333,7 +1333,8 @@
"ReadLess": "Leer menos",
"ReadMore": "Leer más...",
"CommitImageName": "Nombre de la imagen confirmada",
"IdleCheckExpirationWarning": "Las sesiones pueden finalizarse según los resultados de los controles de inactividad."
"IdleCheckExpirationWarning": "Las sesiones pueden finalizarse según los resultados de los controles de inactividad.",
"FailToRenameSession": "La solicitud para cambiar el nombre de la sesión ha fallado."
},
"settings": {
"AllowAgentSideRegistration": "Permitir el registro del agente",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/fi.json
Original file line number Diff line number Diff line change
Expand Up @@ -1332,7 +1332,8 @@
"ReadLess": "Lue vähemmän",
"ReadMore": "Lue lisää...",
"CommitImageName": "Sitoutunut kuvan nimi",
"IdleCheckExpirationWarning": "Istunnot voidaan lopettaa joutokäyntitarkastusten tulosten perusteella."
"IdleCheckExpirationWarning": "Istunnot voidaan lopettaa joutokäyntitarkastusten tulosten perusteella.",
"FailToRenameSession": "Pyyntö istunnon nimen muuttamiseksi epäonnistui."
},
"settings": {
"AllowAgentSideRegistration": "Salli agenttipuolen rekisteröinti",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,8 @@
"ReadLess": "Lire moins",
"ReadMore": "Lire la suite...",
"CommitImageName": "Nom de l'image validée",
"IdleCheckExpirationWarning": "Les sessions peuvent être interrompues en fonction des résultats des contrôles d'inactivité."
"IdleCheckExpirationWarning": "Les sessions peuvent être interrompues en fonction des résultats des contrôles d'inactivité.",
"FailToRenameSession": "La demande de modification du nom de la session a échoué."
},
"button": {
"Cancel": "Annuler",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/id.json
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,8 @@
"ReadLess": "Baca lebih sedikit",
"ReadMore": "Baca Selengkapnya...",
"CommitImageName": "Nama gambar yang berkomitmen",
"IdleCheckExpirationWarning": "Sesi dapat dihentikan berdasarkan hasil Pemeriksaan Idleness."
"IdleCheckExpirationWarning": "Sesi dapat dihentikan berdasarkan hasil Pemeriksaan Idleness.",
"FailToRenameSession": "Permintaan untuk mengubah nama sesi gagal."
},
"button": {
"Cancel": "Batalkan",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/it.json
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,8 @@
"ReadLess": "Leggi di più",
"ReadMore": "Per saperne di più...",
"CommitImageName": "Nome dell'immagine confermata",
"IdleCheckExpirationWarning": "Le sessioni possono essere interrotte in base ai risultati dei controlli di inattività."
"IdleCheckExpirationWarning": "Le sessioni possono essere interrotte in base ai risultati dei controlli di inattività.",
"FailToRenameSession": "La richiesta di modifica del nome della sessione è fallita."
},
"button": {
"Cancel": "Annulla",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/ja.json
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,8 @@
"ReadLess": "内容折りたたみ",
"ReadMore": "もっと詳しく...",
"CommitImageName": "コミットされたイメージ名",
"IdleCheckExpirationWarning": "セッションはアイドル状態チェックの結果に基づいて終了される場合があります。"
"IdleCheckExpirationWarning": "セッションはアイドル状態チェックの結果に基づいて終了される場合があります。",
"FailToRenameSession": "セッション名変更要求が失敗しました。"
},
"button": {
"Cancel": "キャンセル",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/ko.json
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,8 @@
"ReadLess": "내용 접기",
"ReadMore": "더 알아보기...",
"CommitImageName": "커밋 이미지 이름",
"IdleCheckExpirationWarning": "유휴 상태 확인 결과에 따라 세션이 종료될 수 있습니다."
"IdleCheckExpirationWarning": "유휴 상태 확인 결과에 따라 세션이 종료될 수 있습니다.",
"FailToRenameSession": "세션 이름 변경 요청이 실패했습니다."
},
"modelService": {
"Services": "모델 서비스",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/mn.json
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,8 @@
"ReadLess": "Бага унш",
"ReadMore": "Цааш унших...",
"CommitImageName": "Оруулсан зургийн нэр",
"IdleCheckExpirationWarning": "Сул зогсолтын шалгалтын үр дүнд үндэслэн хуралдааныг зогсоож болно."
"IdleCheckExpirationWarning": "Сул зогсолтын шалгалтын үр дүнд үндэслэн хуралдааныг зогсоож болно.",
"FailToRenameSession": "Сешн нэрийг өөрчлөх хүсэлтийг өөрчлөх ажиллагаа амжилтгүй боллоо."
},
"button": {
"Cancel": "Цуцлах",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/ms.json
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,8 @@
"ReadLess": "Kurangkan membaca",
"ReadMore": "Baca Lagi...",
"CommitImageName": "Nama imej komited",
"IdleCheckExpirationWarning": "Sesi boleh ditamatkan berdasarkan keputusan Semakan Kemalasan."
"IdleCheckExpirationWarning": "Sesi boleh ditamatkan berdasarkan keputusan Semakan Kemalasan.",
"FailToRenameSession": "Permintaan perubahan nama sesi gagal."
},
"button": {
"Cancel": "Batal",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/pl.json
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,8 @@
"ReadLess": "Czytaj mniej",
"ReadMore": "Czytaj więcej...",
"CommitImageName": "Zatwierdzona nazwa obrazu",
"IdleCheckExpirationWarning": "Sesje mogą zostać zakończone na podstawie wyników kontroli bezczynności."
"IdleCheckExpirationWarning": "Sesje mogą zostać zakończone na podstawie wyników kontroli bezczynności.",
"FailToRenameSession": "Żądanie zmiany nazwy sesji nie powiodło się."
},
"button": {
"Cancel": "Anuluj",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/pt-BR.json
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,8 @@
"ReadLess": "Ler menos",
"ReadMore": "Ler mais...",
"CommitImageName": "Nome da imagem confirmada",
"IdleCheckExpirationWarning": "As sessões podem ser encerradas com base nos resultados das verificações de inatividade."
"IdleCheckExpirationWarning": "As sessões podem ser encerradas com base nos resultados das verificações de inatividade.",
"FailToRenameSession": "O pedido de alteração do nome da sessão falhou."
},
"button": {
"Cancel": "Cancelar",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/pt.json
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,8 @@
"ReadLess": "Ler menos",
"ReadMore": "Ler mais...",
"CommitImageName": "Nome da imagem confirmada",
"IdleCheckExpirationWarning": "As sessões podem ser encerradas com base nos resultados das verificações de inatividade."
"IdleCheckExpirationWarning": "As sessões podem ser encerradas com base nos resultados das verificações de inatividade.",
"FailToRenameSession": "O pedido de alteração do nome da sessão falhou."
},
"button": {
"Cancel": "Cancelar",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/ru.json
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,8 @@
"ReadLess": "Читать далее",
"ReadMore": "Читать далее...",
"CommitImageName": "Имя зафиксированного изображения",
"IdleCheckExpirationWarning": "Сеансы могут быть прекращены по результатам проверок простоя."
"IdleCheckExpirationWarning": "Сеансы могут быть прекращены по результатам проверок простоя.",
"FailToRenameSession": "Запрос на изменение имени сеанса завершился неудачей."
},
"button": {
"Cancel": "Отмена",
Expand Down
4 changes: 2 additions & 2 deletions resources/i18n/th.json
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,8 @@
"ReadLess": "อ่านน้อยลง",
"ReadMore": "อ่านเพิ่มเติม...",
"CommitImageName": "ชื่อภาพที่มุ่งมั่น",
"IdleCheckExpirationWarning": "เซสชันอาจถูกยกเลิกโดยขึ้นอยู่กับผลลัพธ์ของการตรวจสอบความไม่มีการใช้งาน"
"IdleCheckExpirationWarning": "เซสชันอาจถูกยกเลิกโดยขึ้นอยู่กับผลลัพธ์ของการตรวจสอบความไม่มีการใช้งาน",
"FailToRenameSession": "คำขอเปลี่ยนชื่อเซสชันล้มเหลว"
},
"modelService": {
"Services": "บริการ",
Expand Down Expand Up @@ -665,7 +666,6 @@
"ExtendLoginSession": "ขยายเซสชันการเข้าสู่ระบบ",
"Cores": "คอร์",
"InvalidJSONFormat": "รูปแบบ JSON ไม่ถูกต้อง",
"NSelected": "{{count}} เลือก",
"LastUpdated": "อัปเดตล่าสุด"
},
"credential": {
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/tr.json
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,8 @@
"ReadLess": "Daha az oku",
"ReadMore": "Daha Fazlasını Oku...",
"CommitImageName": "Taahhüt edilen resim adı",
"IdleCheckExpirationWarning": "Idleness Check sonuçlarına göre oturumlar sonlandırılabilir."
"IdleCheckExpirationWarning": "Idleness Check sonuçlarına göre oturumlar sonlandırılabilir.",
"FailToRenameSession": "Oturum adını değiştirme isteği başarısız oldu."
},
"button": {
"Cancel": "İptal etmek",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/vi.json
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,8 @@
"ReadLess": "Đọc ít hơn",
"ReadMore": "Đọc thêm...",
"CommitImageName": "Tên hình ảnh đã cam kết",
"IdleCheckExpirationWarning": "Các phiên có thể bị chấm dứt dựa trên kết quả Kiểm tra trạng thái rảnh rỗi."
"IdleCheckExpirationWarning": "Các phiên có thể bị chấm dứt dựa trên kết quả Kiểm tra trạng thái rảnh rỗi.",
"FailToRenameSession": "Yêu cầu thay đổi tên phiên không thành công."
},
"button": {
"Cancel": "Huỷ bỏ",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,8 @@
"ReadLess": "更多信息",
"ReadMore": "阅读全文...",
"CommitImageName": "提交的图片名称",
"IdleCheckExpirationWarning": "会话可能会根据空闲检查的结果而终止。"
"IdleCheckExpirationWarning": "会话可能会根据空闲检查的结果而终止。",
"FailToRenameSession": "更改会话名称的请求失败。"
},
"button": {
"Cancel": "取消",
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/zh-TW.json
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,8 @@
"ReadLess": "更多信息",
"ReadMore": "阅读全文...",
"CommitImageName": "提交的圖片名稱",
"IdleCheckExpirationWarning": "會話可能會根據空閒檢查的結果而終止。"
"IdleCheckExpirationWarning": "會話可能會根據空閒檢查的結果而終止。",
"FailToRenameSession": "更改会话名称的请求失败。"
},
"button": {
"Cancel": "取消",
Expand Down

0 comments on commit 45cc40d

Please sign in to comment.