feat(FR-492): terminiate sessions in NEO session list #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
yomybaby
changed the title
yomybaby
force-pushed
the
feature/termnaite-session-in-neo-session-list
branch
from
473f193 to
a499b90
Compare
yomybaby
force-pushed
the
feature/termnaite-session-in-neo-session-list
branch
from
a499b90 to
5711de4
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.66% (-0.01% 🔻) |
401/8609 |
| 🔴 | Branches | 4.05% (-0% 🔻) |
239/5905 |
| 🔴 | Functions | 2.81% (-0.02% 🔻) |
78/2776 |
| 🔴 | Lines | 4.58% (-0.01% 🔻) |
386/8423 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | usePromiseTracker.ts | 0% | 100% | 0% | 0% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | helper/index.tsx | 47.85% (-2.73% 🔻) |
43.18% (-0.25% 🔻) |
34% (-6.48% 🔻) |
48.78% (-2.85% 🔻) |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from e5b31e0
yomybaby
force-pushed
the
feature/termnaite-session-in-neo-session-list
branch
from
5711de4 to
fb90a8a
Compare
yomybaby
force-pushed
the
feature/termnaite-session-in-neo-session-list
branch
3 times, most recently
from
577d4b0 to
ade7485
Compare
yomybaby
force-pushed
the
feature/termnaite-session-in-neo-session-list
branch
from
ade7485 to
0e1ee52
Compare
This was referenced Feb 16, 2025
yomybaby
force-pushed
the
feature/termnaite-session-in-neo-session-list
branch
from
0e1ee52 to
1ac91d3
Compare
agatha197
requested changes
Feb 17, 2025
ironAiken2
requested changes
Feb 17, 2025
ironAiken2
requested changes
Feb 17, 2025
react/src/components/ComputeSessionNodeItems/TerminateSessionModal.tsx
Outdated
Show resolved
Hide resolved
yomybaby
force-pushed
the
feature/termnaite-session-in-neo-session-list
branch
from
6e7f178 to
427bcd1
Compare
yomybaby
force-pushed
the
feature/termnaite-session-in-neo-session-list
branch
from
427bcd1 to
edb8e62
Compare
agatha197
requested changes
Feb 17, 2025
yomybaby
force-pushed
the
feature/termnaite-session-in-neo-session-list
branch
from
edb8e62 to
4253c88
Compare
Merge activity
|
resolves #3127 (FR-492)  Adds multi-session termination functionality to the compute session list page. Users can now select multiple sessions and terminate them simultaneously. The termination process includes proper error handling and status tracking for each session. Key changes: - Added checkbox selection to session list table - Implemented batch termination modal for multiple sessions - Created promise tracker hook to manage multiple termination requests - Added session count and terminate button in the list header when sessions are selected - Updated translations for selected item count across multiple languages **Checklist:** - [ ] Test case(s) to demonstrate the difference of before/after - Select multiple sessions and verify they can be terminated together - Verify error handling when terminating multiple sessions - Check that session list updates correctly after batch termination - Validate selected sessions persist between page navigation - Confirm selections clear when filters change
graphite-app
bot
force-pushed
the
feature/termnaite-session-in-neo-session-list
branch
from
4253c88 to
e5b31e0
Compare
graphite-app
bot
deleted the
feature/termnaite-session-in-neo-session-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3127 (FR-492)
Adds multi-session termination functionality to the compute session list page. Users can now select multiple sessions and terminate them simultaneously. The termination process includes proper error handling and status tracking for each session.
Key changes:
Checklist: