Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-527): introduce BAIFetchKeyButton #3169

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Feb 16, 2025

resolves #3174 (FR-567)

Adds auto-refresh functionality to the compute session list page with a dedicated refresh button that shows loading state and supports automatic updates every 15 seconds. The table now displays a loading state with reduced opacity during updates and shows the total number of items.

Key changes:

  • New BAIFetchKeyButton component for manual/automatic data refresh
  • Enhanced table loading states with smooth opacity transitions
  • Added "Last Updated" translations across all languages
  • Improved badge visibility for running sessions
  • Fixed state updates in useDeferredQueryParams hook

Copy link
Member Author

yomybaby commented Feb 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:L 100~500 LoC labels Feb 16, 2025
@yomybaby yomybaby force-pushed the feature/termnaite-session-in-neo-session-list branch from 0e1ee52 to 1ac91d3 Compare February 16, 2025 23:01
@yomybaby yomybaby force-pushed the feature/bai-fetchkey-button branch from fb9eeef to b4f9d27 Compare February 16, 2025 23:01
@yomybaby yomybaby changed the title feature: introduce BAIFetchKeyButton feat: introduce BAIFetchKeyButton Feb 16, 2025
@yomybaby yomybaby force-pushed the feature/bai-fetchkey-button branch 2 times, most recently from 3b234d0 to caf22f2 Compare February 17, 2025 00:37
@yomybaby yomybaby changed the base branch from feature/termnaite-session-in-neo-session-list to fix/session-list-filter-wrap February 17, 2025 00:37
@yomybaby yomybaby changed the title feat: introduce BAIFetchKeyButton feat(FR-527): introduce BAIFetchKeyButton Feb 17, 2025
@yomybaby yomybaby marked this pull request as ready for review February 17, 2025 00:57
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some pages show Refresh text to the refresh button. Doesn't it need?

Copy link
Member Author

Yes, the refresh button without title is a default in NEO design.

@yomybaby yomybaby force-pushed the fix/session-list-filter-wrap branch from ecde3ec to b2e8163 Compare February 17, 2025 02:45
@yomybaby yomybaby force-pushed the feature/bai-fetchkey-button branch from caf22f2 to e357a47 Compare February 17, 2025 02:45
@yomybaby yomybaby requested a review from agatha197 February 17, 2025 03:28
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby force-pushed the fix/session-list-filter-wrap branch from b2e8163 to d8baa2d Compare February 17, 2025 04:45
@yomybaby yomybaby force-pushed the feature/bai-fetchkey-button branch from e357a47 to dccff75 Compare February 17, 2025 04:45
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby force-pushed the fix/session-list-filter-wrap branch from d8baa2d to 25be626 Compare February 17, 2025 07:44
@yomybaby yomybaby force-pushed the feature/bai-fetchkey-button branch from dccff75 to 216b0b9 Compare February 17, 2025 07:44
Copy link

graphite-app bot commented Feb 17, 2025

Merge activity

@yomybaby yomybaby force-pushed the fix/session-list-filter-wrap branch from 25be626 to dd32627 Compare February 17, 2025 08:26
@yomybaby yomybaby force-pushed the feature/bai-fetchkey-button branch from 216b0b9 to cae10f8 Compare February 17, 2025 08:26
resolves #3174 (FR-567)

Adds auto-refresh functionality to the compute session list page with a dedicated refresh button that shows loading state and supports automatic updates every 15 seconds. The table now displays a loading state with reduced opacity during updates and shows the total number of items.

Key changes:
- New `BAIFetchKeyButton` component for manual/automatic data refresh
- Enhanced table loading states with smooth opacity transitions
- Added "Last Updated" translations across all languages
- Improved badge visibility for running sessions
- Fixed state updates in `useDeferredQueryParams` hook
@graphite-app graphite-app bot force-pushed the fix/session-list-filter-wrap branch from dd32627 to ba1b285 Compare February 17, 2025 08:29
@graphite-app graphite-app bot force-pushed the feature/bai-fetchkey-button branch from cae10f8 to af19cee Compare February 17, 2025 08:29
Base automatically changed from fix/session-list-filter-wrap to main February 17, 2025 08:31
@graphite-app graphite-app bot merged commit af19cee into main Feb 17, 2025
4 checks passed
@graphite-app graphite-app bot deleted the feature/bai-fetchkey-button branch February 17, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:ux UI / UX issue. size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEO: Improve auto refetch handling for session list
3 participants