Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labwc icons: Add updated icons #9

Merged
merged 1 commit into from
Mar 16, 2024
Merged

labwc icons: Add updated icons #9

merged 1 commit into from
Mar 16, 2024

Conversation

rcalixte
Copy link
Contributor

@rcalixte rcalixte commented Feb 3, 2024

Ref: #7, labwc/labwc#1462

cc @Consolatis @johanmalm (The PR is open for edits as needed. I'll try to remember not to rebase.)

01micko
01micko previously requested changes Feb 4, 2024
Copy link

@01micko 01micko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symbolic icons as far as I know only use one color so I don't think black and white fits the bill.

<?xml version="1.0" encoding="UTF-8"?>
<!--labwc logo #2 (C) Johan Malm LICENSE: CC BY-SA 4.0-->
<svg xmlns="http://www.w3.org/2000/svg" width="256px" height="256px"
     viewbox="0 0 256 256"
     stroke-linecap="round" stroke-linejoin="round" stroke-width="12">
  <path fill="none" stroke="#000000" d="m 26 68 91 55 v 108 l -76 -61 z" />
  <path fill="#000000" stroke="#000000" d="m 229 68 -91 55 v 108 l 76 -61 z" />
</svg>

@rcalixte
Copy link
Contributor Author

rcalixte commented Feb 4, 2024

Symbolic icons as far as I know only use one color so I don't think black and white fits the bill.

Just when I thought I'd finally gotten this right... Would be better to use #ffffff instead though? That seems to work better in my testing.

@01micko
Copy link

01micko commented Feb 4, 2024

Not sure. Trying to research this through freedesktop but all there is is broken links! I might retract that 'request changes' due to lack of information. And I was wrong, not all symbolic icons are single color. Found some with warning signs overlaid and also some battery icons have color.

I would be inclined to add the outline to the white in black. But that's just me.

@01micko 01micko dismissed their stale review February 4, 2024 04:44

lack of information

@rcalixte
Copy link
Contributor Author

rcalixte commented Feb 4, 2024

For reference:

With #000000:
2024-02-03_23-41-35

With #ffffff:
2024-02-03_23-43-01

I'm not sure why it differs to be honest here either. 😅

I would be inclined to add the outline to the white in black. But that's just me.

I'll leave this up to the team. I'll gladly do whatever the wisdom of the crowd desires.

@01micko
Copy link

01micko commented Mar 16, 2024

Since my initial criticism is unfounded I can merge this. The icons are the same as in the main repo so all good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants