-
Notifications
You must be signed in to change notification settings - Fork 9
feat: implement labwc #865 and #1363 #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Oh holy, realized the user of #1363 meant the caption at the README rather than labwc.github.io Anyway, merge or deny/close, I'm fine with both Maybe it could be added somehow as well to the README |
I think "default" conveys the wrong impression for the configuration files. They reflect the in-program defaults, but files in that location are never read by the program. "Example" is probably a better term. If there is any ambiguity to resolve, a complex phrase like "Example configuration files, which reflect the default configuration of labwc, [...]" should suffice. |
That panel in the screenshot is not mate-panel but an unreleased one named "Bornel". However we should likely not refer to it as its not publicly available and I don't feel like maintaining it currently. The last time I tested mate-panel it provided a really reduced feature set when running within a wayland session. Maybe we should look into creating a new screenshot with a panel like sfwbar or xfce4-panel instead (and maybe the labwc logo, centered on a black background set via Regarding Edit:
|
I'm waiting for a final consensus about #7, after that my idea is to do some nice wallpapers for labwc-artwork and push a screenshot of one of them, a plain black one with the logo (cube + text), default sfwbar config and labwc-tweaks, to this PR Edit: though if there's an urge to merge this for 0.7.1 release, a wallpaper without the text and just the logo could do the job too... |
Good call, I'd like to add labwc/labwc-artwork#7 to the milestone for 0.7.1 but as its in a different repo, GH won't allow for that. Personally I still stand by my statement in the thread that the offset to the top should be increased, similar to the organization logo at https://github.com/labwc Edit: |
I'm not at the day of what is going on in that issue that much Basically, I'm mostly waiting for that issue could define a final SVG logo that defines the project face. off-topic* Edit: or maybe deprecate the logo of the cube + font and just use the cube |
hmm, failed to notice that "orca" logo even it was mentioned in that # 7...
(manual trial&errors, fun to a certain point :D) |
Depends on: #43 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider refactoring. It doesn't flow well first saying that config files are located at /usr/share/.... (which they might not be btw) and then say OS/distros might include config files.
@@ -13,13 +13,14 @@ be controlled with dbus, sway/i3-IPC or other technology. The reason for this is | |||
that we believe that custom IPCs and protocols create a fragmentation that | |||
hinders general Wayland adoption. | |||
|
|||
<a href="img/scrot1.png"> | |||
<img src="img/scrot1-small.png"> | |||
<a href="img/scrot2.png"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to change the default screenshot without some dialogue first.
Also, I thing a "figure caption" looks like a report or something. That's why I added a link in template_pre.md instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest removing the caption and when clicking the img (scrot) it redirects you to the obligatory-screenshot page
It's easier to review + merge if you submit changes in smaller batches. |
Apologies if I've disturbed anyone's sleep
Implements: