Skip to content

feat: implement VirtualMachine::is_accessed #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Mar 24, 2025

Implement public API for is_accessed from Relocatable.

Description

When using the VM to run the Starknet OS, we require a public API to check if a cell is accessed (for segmented contract loading).

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

Signed-off-by: Dori Medini <[email protected]>
@gabrielbosio
Copy link
Collaborator

Hi @dorimedini-starkware, this looks good but it would be great if you add why is this change necessary in the description of the PR

@dorimedini-starkware
Copy link
Collaborator Author

Hi @dorimedini-starkware, this looks good but it would be great if you add why is this change necessary in the description of the PR

Sure thing, done

@JulianGCalderon
Copy link
Contributor

Hi @dorimedini-starkware. Could you add some tests for the new methods? The coverage job is failing: https://github.com/lambdaclass/cairo-vm/pull/2028/checks?check_run_id=39449669998

Signed-off-by: Dori Medini <[email protected]>
@dorimedini-starkware
Copy link
Collaborator Author

Hi @dorimedini-starkware. Could you add some tests for the new methods? The coverage job is failing: https://github.com/lambdaclass/cairo-vm/pull/2028/checks?check_run_id=39449669998

Done. Couldn't run locally (build errors due to missing JSON files...?), running CI

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.54%. Comparing base (63fa1b7) to head (6619ad2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2024   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files         102      102           
  Lines       42755    42778   +23     
=======================================
+ Hits        41276    41299   +23     
  Misses       1479     1479           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielbosio gabrielbosio enabled auto-merge March 26, 2025 22:37
@dorimedini-starkware
Copy link
Collaborator Author

@JulianGCalderon can you update this?

@dorimedini-starkware
Copy link
Collaborator Author

closing in favor of this

auto-merge was automatically disabled March 27, 2025 13:50

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants