Skip to content

Fix broken links #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2025
Merged

Fix broken links #303

merged 3 commits into from
Jan 5, 2025

Conversation

edwardalee
Copy link
Contributor

This PR fixes a large number of broken links, fixing #240. Running yarn build no longer reports any broken links. It does still give a warning, one that I can't figure out:

[WARNING] {"moduleIdentifier":"/Users/edwardlee/git/lf-lang.github.io/node_modules/babel-loader/lib/index.js??ruleSet[1].rules[6].use[0]!/Users/edwardlee/git/lf-lang.github.io/src/components/LinguaFrancaMultiTargetUtils/DynamicMultiTargetCodeblock.tsx","moduleName":"./src/components/LinguaFrancaMultiTargetUtils/DynamicMultiTargetCodeblock.tsx","loc":"35:119-129","message":"Critical dependency: the request of a dependency is an expression","compilerPath":"server"}

I believe this is orthogonal to this PR, but it may prevent us from being able to treat warnings as fatal errors, which would help prevent broken links in the future.

This was referenced Jan 5, 2025
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lhstrh
Copy link
Member

lhstrh commented Jan 5, 2025

I think the warning is about webpack being confused because it encountered a dynamic import or require statement that it cannot resolve statically at build time.

@edwardalee edwardalee merged commit dc55b7b into main Jan 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants