-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 0.50 pin libp2p-quic prerelease deps #3549
Conversation
version = "0.7.0-alpha" | ||
version = "0.7.0-alpha.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is released without the 0
so I think we can't just change that now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, would cargo publish
actually reject this version? the next version (and latest) is -alpha.2
, does it have a check to ensure the prerelease number is incremental? afaik, since it's still unique it'd work. Also just tried a cargo publish --dry-run
and it seems to pass at least on that side of things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the upside of publishing a new version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a version of libp2p-quic to depend on from libp2p 0.50 that has libp2p-tls pinned, so that it wont pull [email protected] anymore but instead correctly use tls@-alpha (which is still causing libp2p 0.50.1 to break)
Also see the comment from @mxinden #3548 (comment)
Since a later version of quic has already been released, to avoid mixing up the versions i used alpha.0 for the version to retain some ordering but still have a unique one to pin libp2p against
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, you are completely right. I forgot about the dependency from libp2p-quic
to libp2p-tls
.
Any updates here? |
I still need to verify that we can actually release this. @mxinden do you know? |
Do you actually need this to fix a problem where you can't just keep the version pinned in |
We aren't currently pushing locks atm. To temporarily fix things on our end, we're now using a patch with the git rev for 0.50.1, which works since it loads all deps from that commit and ignores the crate releases. We are planning to update to 0.51 as well, although it'll take some time as migration was not as easy as initially expected. |
Okay thanks for that. Feel free to tag us in any update PRs if you have questions! cc @mxinden The update to 0.51 seems to be more difficult than expected so I think it is worth trying to resolve this. |
I am proposing a different strategy on how to handle this: #3580. |
Closing this as a wont-fix (for the #3580 should prevent this in the future. |
Description
backport of #3548, and should fully resolve #3537
Notes
-alpha.0
-alpha
Change checklist