Skip to content

fix: 0.50 pin libp2p-quic prerelease deps #3549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: 0.50 pin libp2p-quic prerelease deps #3549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name = "libp2p"
edition = "2021"
rust-version = "1.62.0"
description = "Peer-to-peer networking library"
version = "0.50.1"
version = "0.50.2"
authors = ["Parity Technologies <[email protected]>"]
license = "MIT"
repository = "https://github.com/libp2p/rust-libp2p"
Expand Down Expand Up @@ -120,7 +120,7 @@ smallvec = "1.6.1"
libp2p-deflate = { version = "0.38.0", path = "transports/deflate", optional = true }
libp2p-dns = { version = "0.38.0", path = "transports/dns", optional = true }
libp2p-mdns = { version = "0.42.0", path = "protocols/mdns", optional = true }
libp2p-quic = { version = "=0.7.0-alpha", path = "transports/quic", optional = true }
libp2p-quic = { version = "=0.7.0-alpha.0", path = "transports/quic", optional = true }
libp2p-tcp = { version = "0.38.0", path = "transports/tcp", optional = true }
libp2p-tls = { version = "=0.1.0-alpha", path = "transports/tls", optional = true }
libp2p-webrtc = { version = "=0.4.0-alpha", path = "transports/webrtc", optional = true }
Expand Down
4 changes: 2 additions & 2 deletions transports/quic/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "libp2p-quic"
version = "0.7.0-alpha"
version = "0.7.0-alpha.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is released without the 0 so I think we can't just change that now?

Copy link
Contributor Author

@ozwaldorf ozwaldorf Mar 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, would cargo publish actually reject this version? the next version (and latest) is -alpha.2, does it have a check to ensure the prerelease number is incremental? afaik, since it's still unique it'd work. Also just tried a cargo publish --dry-run and it seems to pass at least on that side of things

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the upside of publishing a new version?

Copy link
Contributor Author

@ozwaldorf ozwaldorf Mar 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a version of libp2p-quic to depend on from libp2p 0.50 that has libp2p-tls pinned, so that it wont pull [email protected] anymore but instead correctly use tls@-alpha (which is still causing libp2p 0.50.1 to break)

Also see the comment from @mxinden #3548 (comment)

Since a later version of quic has already been released, to avoid mixing up the versions i used alpha.0 for the version to retain some ordering but still have a unique one to pin libp2p against

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, you are completely right. I forgot about the dependency from libp2p-quic to libp2p-tls.

authors = ["Parity Technologies <[email protected]>"]
edition = "2021"
rust-version = "1.62.0"
Expand All @@ -15,7 +15,7 @@ futures = "0.3.15"
futures-timer = "3.0.2"
if-watch = "3.0.0"
libp2p-core = { version = "0.38.0", path = "../../core" }
libp2p-tls = { version = "0.1.0-alpha", path = "../tls" }
libp2p-tls = { version = "=0.1.0-alpha", path = "../tls" }
log = "0.4"
parking_lot = "0.12.0"
quinn-proto = { version = "0.9.0", default-features = false, features = ["tls-rustls"] }
Expand Down