feat: [draft] vaults validators triggerable exits #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add role ADD_FULL_WITHDRAWAL_REQUEST_ROLE for full withdrawal requests.
…hdrawal-credentials
Access pubkeys and amounts directly instead of copying them to memory.
pass pubkeys as array of bytes
…o feat/waults-triggerable-exits # Conflicts: # scripts/scratch/steps/0120-initialize-non-aragon-contracts.ts
# Conflicts: # contracts/0.8.25/vaults/Dashboard.sol # test/integration/vaults-happy-path.integration.ts
…le-exits # Conflicts: # contracts/0.8.9/WithdrawalVault.sol # contracts/common/lib/TriggerableWithdrawals.sol
…le-exits # Conflicts: # contracts/common/lib/TriggerableWithdrawals.sol # test/common/lib/triggerableWithdrawals/triggerableWithdrawals.test.ts
tamtamchik
force-pushed
the
feat/vaults-triggerable-exits
branch
from
e106d9c to
8c1a908
Compare
tamtamchik
force-pushed
the
feat/vaults-triggerable-exits
branch
from
8c1a908 to
748f8c9
Compare
tamtamchik
force-pushed
the
feat/vaults-triggerable-exits
branch
from
7c8c374 to
33f1d5c
Compare
tamtamchik
force-pushed
the
feat/vaults-triggerable-exits
branch
from
d104b3e to
dd67b36
Compare
tamtamchik
force-pushed
the
feat/vaults-triggerable-exits
branch
from
46b9aab to
ebd830d
Compare
tamtamchik
requested review from
folkyatina and
TheDZhon
and removed request for
a team
tamtamchik
force-pushed
the
feat/vaults-triggerable-exits
branch
from
d390031 to
2a5de07
Compare
tamtamchik
force-pushed
the
feat/vaults-triggerable-exits
branch
from
2a5de07 to
c2facaf
Compare
tamtamchik
commented
Feb 8, 2025
| expect(receipt.logs.length).to.equal(numberOfKeys); | ||
| }); | ||
|
|
||
| it("handles large number of validator keys", async () => { |
There was a problem hiding this comment.
Do we need some kind of limit inside the function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add options for node operator, vault owner, and dao to exit validators from the beacon chain.
requestValidatorExit– just an event fromREQUEST_VALIDATOR_EXIT_ROLEto NO to exit validators.initiateValidatorWithdrawal- EIP-7002-based trigger for validators exit by VO of NO. Will trigger complete validators exit.initiatePartialValidatorWithdrawal- EIP-7002-based trigger for validators exit by VO of NO. This will trigger partial validator withdrawals from the beacon chain.forceWithdrawal– EIP-7002-based trigger for validators to exit that can be done via VaultHub to rebalance unbalanced vault back to balanced state, time-locked to allow the owner to rebalance without exiting the validators from the beacon chainExtras:
isBalancedwas removed from the StakingVault to avoid confusion.TODO: