Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the incorrect name of @dependabot in check-workflow-write-permission.sh #5431

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

ikhoon
Copy link
Contributor

@ikhoon ikhoon commented Jan 31, 2024

GITHUB_ACTOR name of @dependabot is not dependabot but dependabot[bot].

…sion.sh`

`GITHUB_ACTOR` name of @dependabot is not `dependabot` but
`dependabot[bot].
@ikhoon
Copy link
Contributor Author

ikhoon commented Jan 31, 2024

I've updated the script on the CI machines and dependabot[bot] was allowed to update workflow files.
https://github.com/line/armeria/actions/runs/7719907093/job/21056328357?pr=5429

Copy link
Contributor

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0bbef32) 73.99% compared to head (6d18d81) 73.99%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5431   +/-   ##
=========================================
  Coverage     73.99%   73.99%           
+ Complexity    20746    20741    -5     
=========================================
  Files          1800     1800           
  Lines         76425    76425           
  Branches       9728     9728           
=========================================
+ Hits          56552    56553    +1     
+ Misses        15269    15266    -3     
- Partials       4604     4606    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇 👍 🙇

@ikhoon ikhoon merged commit e99b924 into line:main Feb 1, 2024
17 checks passed
@ikhoon ikhoon deleted the dependabotbot branch February 1, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants