fix(ebean-dao): move SharedSchemaCache pre-warm to EbeanLocalAccess c…#619
Open
ybz1013 wants to merge 1 commit into
Open
fix(ebean-dao): move SharedSchemaCache pre-warm to EbeanLocalAccess c…#619ybz1013 wants to merge 1 commit into
ybz1013 wants to merge 1 commit into
Conversation
…onstructor ensureSchemaUpToDate() is LiX'd off in some services (e.g. MGA), so pre-warming was never firing in production. Moving registerAndPreWarm() into the constructor guarantees it runs at bean creation time regardless of whether ensureSchemaUpToDate() is called. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…onstructor
ensureSchemaUpToDate() is LiX'd off in some services (e.g. MGA), so pre-warming was never firing in production. Moving registerAndPreWarm() into the constructor guarantees it runs at bean creation time regardless of whether ensureSchemaUpToDate() is called.
Summary
SharedSchemaCachepre-warming fromensureSchemaUpToDate()into theEbeanLocalAccessconstructor so it fires at bean creation time regardless of whether
ensureSchemaUpToDate()is calledensureSchemaUpToDate()is LiX'd off in MGA so pre-warming was never executing in productionensureSchemaUpToDate()— schema evolution DDL stillruns there; only the cache warm-up moved to constructor
Testing Done
SharedSchemaCacheTest(14 tests) — passEbeanLocalAccessTest— passEbeanLocalAccessTestWithoutServiceIdentifier— passChecklist
Conforms to Commit Message Format
The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
Docs related to the changes have been added/updated (if applicable)